[0.15.37] Negative productivity bonus doesn't work

[eradicator]

What?

Productivity modules with negative bonuses show correctly on tooltip/hover over, but the productivity is not actually reduced below 100%. Additionally the progress bar display sneaks out of the window

negative_productivity_display_bug.png (141.8 KiB) Viewed 4141 times

Code: Select all

data.raw.module['productivity-module'].effect.productivity = {bonus = -0.5}

Expected behavior

The bonus progress bar shouldn't be rendered at all. Instead the normal progress bar should move slower. And at -50% productivity the machine should consume more resources (i.e. 2 plates to make 2 copper cables in the example).

This bug is related to my interface request Assembling-machine with built-in productivity.

[Klonan]

Negative total productivity will probably not happen,
The whole system is not designed to 'eat' extra resources

Modules reducing productivity make some sense, they can reduce the bonus from other modules or effects

So I would say that when the bonus production is calculated, its always either the value or 0

[Klonan]

For 0.16 the bonus bar and GUI etc. won't show for negative productivity values

The rest of it 'not working' isn't a bug

[eradicator]

Negative total productivity will probably not happen,
The whole system is not designed to 'eat' extra resources

Yea. I feared as much. Would you mind fixing the "hover-over-tooltip" for entities with total negative productivity to:

"Productivity: -0% (-0% = limit)"

like it does for electricity when you have more than -80% consumption bonus?

[Klonan]

Negative total productivity will probably not happen,
The whole system is not designed to 'eat' extra resources

Yea. I feared as much. Would you mind fixing the "hover-over-tooltip" for entities with total negative productivity to:

"Productivity: -0% (-0% = limit)"

like it does for electricity when you have more than -80% consumption bonus?

Okay, it will show 'Productivity: -0% = limit'