[0.15.34] Some ogg files cause crash

This subforum contains all the issues which we already resolved.
Post Reply
wvlad
Fast Inserter
Fast Inserter
Posts: 215
Joined: Thu Jul 13, 2017 9:55 pm
Contact:

[0.15.34] Some ogg files cause crash

Post by wvlad » Tue Aug 29, 2017 8:05 pm

Code: Select all

for i=1,31 do
	data:extend(
	{
	  {
	    type = "ambient-sound",
	    name = "FTL"..tostring(i),
	    track_type = "main-track",
	    sound =
	    {
	      filename = "__ambientjamsmod-tangerinemusiclabs__/FTL"..tostring(i)..".ogg"
	    }
	  }
	})
end
log
Ogg files https://1drv.ms/f/s!AhAvFYRsqyUIg7oYRLWgHq75JgbOIw

User avatar
impetus maximus
Smart Inserter
Smart Inserter
Posts: 1299
Joined: Sat Aug 20, 2016 10:07 pm
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by impetus maximus » Wed Aug 30, 2017 2:14 am

did you validate the ogg files?

wvlad
Fast Inserter
Fast Inserter
Posts: 215
Joined: Thu Jul 13, 2017 9:55 pm
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by wvlad » Wed Aug 30, 2017 7:45 am

No, I used AIMP converter to make them from mp3, they should be fine. The stack trace tells that the exception is thrown not by the codec but by factorio code.

I've found that everything works fine when I remove all tags from them. The tags support needs fixing.

Rseding91
Factorio Staff
Factorio Staff
Posts: 9471
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by Rseding91 » Wed Aug 30, 2017 8:07 am

wvlad wrote:The stack trace tells that the exception is thrown not by the codec but by factorio code.
No, it crashes there because the codec is trying to do something it shouldn't be doing - read data that isn't available.

That's like saying "The car is defective, it blew up when I put nitroglycerin in the gas tank instead of normal gas" :P

That being said, is there any kind of ogg validation that can say the files you're using are conformant to the standard?
If you want to get ahold of me I'm almost always on Discord.

User avatar
Philip017
Filter Inserter
Filter Inserter
Posts: 279
Joined: Thu Sep 01, 2016 11:21 pm
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by Philip017 » Wed Aug 30, 2017 4:01 pm

Rseding91 wrote: That's like saying "The car is defective, it blew up when I put nitroglycerin in the gas tank instead of normal gas" :P
rsedling you come up with some really good analogies and this one gave me a good laugh, thank you for that! :lol:

kovarex
Factorio Staff
Factorio Staff
Posts: 7387
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by kovarex » Thu Aug 31, 2017 11:28 am

As it is suspected that it is most probably problem of the file itself, I'm moving it to pending.
If you provide invalid png, the game will not like it as well.

wvlad
Fast Inserter
Fast Inserter
Posts: 215
Joined: Thu Jul 13, 2017 9:55 pm
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by wvlad » Sat Sep 02, 2017 7:37 am

Is it invalid if it's opened by most players? I don't think so.

Is there a way to verify the files on windows?

posila
Factorio Staff
Factorio Staff
Posts: 3652
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by posila » Sat Sep 02, 2017 1:04 pm

I found the problem.
Thanks for posting the report and giving us example of files that cause the crash. It is fixed for 0.16

User avatar
impetus maximus
Smart Inserter
Smart Inserter
Posts: 1299
Joined: Sat Aug 20, 2016 10:07 pm
Contact:

Re: [0.15.34] Some ogg files cause crash

Post by impetus maximus » Sat Sep 02, 2017 1:13 pm

wvlad wrote:Is it invalid if it's opened by most players? I don't think so.

Is there a way to verify the files on windows?
well VLC can open files that don't conform to a standard.
check out https://www.xiph.org/oggz/ they have windows binaries. no idea how to use them though. :|

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users