[Oxyd] [0.15.16] LOG_AND_ABORT on "Forces to delete is not empty."

[Distelzombie]

Hi there.

We just witnessed a segfault of our server. It was because we created a force in Spacebook called "admin" and deleted it after we realized it is not necessary.
Contrary to what the logfile says nobody was in this force when we deleted it.

I declared this as a factorio bug instead of a mod bug because someone once said the game shouldnt segfault what ever is done.

Code: Select all

Error MainLoop.cpp:859: Exception at tick 81916: Error while running event SpaceBook::on_gui_click (ID 1)
Given force is not valid.
stack traceback:
	__SpaceBook__/control.lua:494: in function 'update_window'
	__SpaceBook__/control.lua:913: in function 'update_windows'
	__SpaceBook__/control.lua:2303: in function <__SpaceBook__/control.lua:1707>
1153.853 Error ServerMultiplayerManager.cpp:94: MultiplayerManager failed: "Error while running event SpaceBook::on_gui_click (ID 1)
Given force is not valid.
stack traceback:
	__SpaceBook__/control.lua:494: in function 'update_window'
	__SpaceBook__/control.lua:913: in function 'update_windows'
	__SpaceBook__/control.lua:2303: in function <__SpaceBook__/control.lua:1707>"
1153.853 Info ServerMultiplayerManager.cpp:670: mapTick(81916) changing state from(InGame) to(Failed)
1225.886 Received SIGTERM, shutting down
1225.886 Info MainLoop.cpp:251: Saving map as /home/tmserver/servers/fac_02562/server/saves/NewWorld.zip
Factorio crashed. Generating symbolized stacktrace, please wait ...
1227.789 Warning Logger.cpp:396: Symbols.size() == 14, usedSize == 8
#0  0x0000000000baee0d in Logger::logStacktrace(StackTraceInfo*) at /tmp/factorio-FqXFm6/src/Util/Logger.cpp:421
#1  0x0000000000b02034 in ForceManager::save(MapSerialiser&) const [clone .constprop.112967] at /tmp/factorio-FqXFm6/src/Force/ForceManager.cpp:69
#2  0x0000000000b848bf in save at /tmp/factorio-FqXFm6/src/Map/Map.cpp:1095
#3  0x0000000000bdc2c1 in saveMap at /tmp/factorio-FqXFm6/src/Scenario/Scenario.cpp:615
#4  0x0000000000bdcf39 in Scenario::saveAs(boost::filesystem::path const&, std::string const&, boost::filesystem::path const&, ProgressObserver*, SaveType) at /tmp/factorio-FqXFm6/src/Scenario/Scenario.cpp:548
#5  0x0000000000ec94b3 in std::string::_M_rep() const at /usr/include/c++/5/bits/basic_string.h:2697
#6  0x00007f4c8e395830 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string() at /usr/include/c++/5/bits/basic_string.h:2943
#7  0x0000000000406de9 in boost::filesystem::path::~path() at /home/build/build_environment/boost_1_61_0/output_linux64/include/boost/filesystem/path.hpp:56
1229.474 Warning Logger.cpp:396: Symbols.size() == 13, usedSize == 7
1229.474 Error ForceManager.cpp:69: Forces to delete is not empty.
Logger::writeStacktrace skipped.
1229.474 Error CrashHandler.cpp:106: Map tick at moment of crash: 81916
1229.474 Error Util.cpp:80: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
1229.488 Error CrashHandler.cpp:232: Received SIGSEGV
Logger::writeStacktrace skipped.
1229.488 Error CrashHandler.cpp:106: Map tick at moment of crash: 81916
1229.488 Error Util.cpp:80: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

[TruePikachu]

Log removed becaused it contains sensitive data, OP has posted a new one --daniel34

[Distelzombie]

Is that your way of saying I should rather include the file contents directly in my post?

Maybe you point out I shared the rcon password...

EDIT; Thank you moderator!

[daniel34]

Is that your way of saying I should rather include the file contents directly in my post?

Posting the file contents with

Code: Select all

 tags is preferred because (1) it allows the devs and others to directly view the log without downloading it if they just want to quickly check it and (2) you can search through them with the forum search feature, e.g. when looking for related logs.

[TruePikachu]

Maybe you point out I shared the rcon password...

I didn't even notice that, actually.

[Distelzombie]

Maybe you point out I shared the rcon password...

I didn't even notice that, actually.

Because of you I've noticed that. Thanks
BTW I dont think a log should contain such infos. It does not help anyone, but create this situations.

[kovarex]

Just to clarify. The script error is the fault of the mod. Our error is the "Forces to delete is not empty" when the game was being saved when it tried to close nicely after a script error.

[Oxyd]

Thanks, should be fixed in 0.15.20.