[0.14.0] Undesired mod dependency behavior

[Mooncat]

Not sure whether it is intentional.
Mods with "factorio_version": "0.13" in its info.json can still work in Factorio 0.14 if its "dependencies" is empty.
But if "dependencies" is not empty, even if the mod does not depend on the base mod, the mod is marked as incompatible.

Steps to reproduce:
1) Download the following unofficial releases of my mods:

color-picker_0.1.1.zip

(16.08 KiB) Downloaded 157 times

player-color_0.1.1.zip

(10.74 KiB) Downloaded 152 times

Both of them have "factorio_version": "0.13".
Color Picker has empty "dependencies".
Player Color depends on Color Picker.

2) Launch Factorio 0.14.
3) Check the installed mods, you will find Color Picker is enabled while Player Color is not.

Expected:
Either both of them are disabled because of "factorio_version": "0.13", or
both of them are enabled because they don't depend on the base mod.

I prefer the second option.
(Or third option: "factorio_version": "0.13" also works in Factorio 0.14 so even mods that depend on the base mod can also work in 0.14)

[credomane]

I noticed this in 0.13 but thought it was just a random thing because 0.12 didn't have the field but 0.13 did. Then when I got home from work I noticed the issue was actually real....I then made a duplicate topic, apparently. You beat me by a few hours. Silly work eating into my factorio time. lol

I can confirm this issue. It is identical to what I tried to explain in my topic here: viewtopic.php?f=7&t=31618


[edit]
I'm pretty sure the way it was meant to work is that factorio_version: "whatever" is meant to forcefully lock the mod to only work factorio version "whatever" not "whatever+1" or "whatever-1". Even if technically the mod will work on "whatever-1", "whatever" and "whatever-1" perfectly fine without any changes. Just for whatever reason the check against factorio_version seems to be done inside the dependency check loop which gets skipped completely if dependencies are empty.

[Mooncat]

Even if technically the mod will work on "whatever-1", "whatever" and "whatever-1" perfectly fine without any changes.

hmmm... I think I have to disagree to this. A normal major update should break mods so they should only work in "whatever". Many 0.12 mods needed to be updated before they can be used in 0.13
But I suggested that 0.14 should also backward support 0.13 mods, because 0.14 is a special major update. It is small. Its purpose is only for experimenting the rewritten multiplayer. Breaking mod support for just one feature is inconvenient to the users IMO.

Just for whatever reason the check against factorio_version seems to be done inside the dependency check loop which gets skipped completely if dependencies are empty.

Yes, and if this is the case, it is definitely a bug.

[binbinhfr]

Mods with "factorio_version": "0.13" in its info.json can still work in Factorio 0.14 if its "dependencies" is empty.

I tried on one of my mod : I deleted the dependencies line, but it does not work for me : even without dependencies, the mod is refused if 0.13 in factorio_version. . "incompatible with current version of the game"

I wonder why it works for you...

[Rseding91]

Fixed for the next version of both 0.13 and 0.14.

[credomane]

It says that in the mod info on the right of the mod list but the mod is actually loaded by the game anyways. Indicated by it being white in mod list and not red.

Then if your mod is actually broken by 0.14 of which there are a few. Then factorio crashes while loading up. Well throws the error about the mod and quits.