[0.13.17] Crash, reproducible: "(250): DrawQueue::draw"

[binbinhfr]

Hi,

I had a crash.

Code: Select all

   0.001 2016-08-19 12:01:21; Factorio 0.13.17 (build 23946, win64, alpha)
   0.001 Operating system: Windows 7 Service Pack 1
   0.001 Program arguments: "c:\Factorio0\bin\x64\factorio0.exe" "--load-game" "C:\Factorio0\saves\testArma07.zip" 
   0.001 Read data path: c:/Factorio0/data
   0.001 Write data path: c:/Factorio0
   0.001 Binaries path: c:/Factorio0/bin
   0.013 Graphics options: [FullScreen: false] [VSync: false] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: high] [Light scale: 100%] [Screen: 255] [DXT: false]
   0.014 Available display adapters: 1
   0.014  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 750 Ti {0x05, [0,0], 1920x1080, 32bit, 60Hz}
   0.014 Create display on adapter 0. Size 1280x720 at position [310, 162].
   0.042 Initialised Direct3D:[0] NVIDIA GeForce GTX 750 Ti; driver: nvd3dumx.dll 10.18.13.6839
   0.045     Video memory size (dedicated video/dedicated system/shared system/available): 1992/0/2048/4037 MB
   0.086 Desktop composition is active.
   0.145 Loading mod core 0.0.0 (data.lua)
   0.150 Loading mod base 0.13.17 (data.lua)
   0.231 Loading mod Armageddon 1.0.5 (data.lua)
   0.277 Checksum for core: 2228900852
   0.277 Checksum for mod base: 2069790529
   0.277 Checksum for mod Armageddon: 214286494
   0.543 Info PlayerData.cpp:45: Local player-data.json available, timestamp 1471600839
   0.543 Info PlayerData.cpp:52: Cloud player-data.json unavailable
   0.649 Initial atlas bitmap size is 16384
   0.651 Created atlas bitmap 16384x5595
   0.926 Created atlas bitmap 4096x968
   0.940 Created atlas bitmap 4096x3648
   6.837 Sprites loaded
   6.837 Convert atlas 4096x968 to: trilinear-filtering 
   6.850 Convert atlas 4096x3648 to: mipmap 
   7.129 Loading sounds...
   8.382 Custom inputs active: 0
   8.415 Factorio initialised
   8.433 Loading map C:\Factorio0\saves\testArma07.zip
   8.474 Info Scenario.cpp:127: Map version 0.13.17-0
   8.565 Checksum for script c:/Factorio0/temp/currently-playing/control.lua: 900459546
   8.567 Checksum for script __Armageddon__/control.lua: 4092013157
  14.154 Error CrashHandler.cpp:135: Exception Code: c0000005, Address: 000000013F6541B0
ModuleBase: 000000013F520000, ImageSize: 01121000, RelativeAddress: 001341b0
  14.154 Error CrashHandler.cpp:145: Exception Context:
rax=00000000411fc6a0, rbx=00000000411fc6a0, rcx=00000000054796f0,
rdx=0000000000000000, rsi=8800001b00b33850, rdi=00000000411fc638,
rip=000000013f6541b0, rsp=00000000231bf7b0, rbp=0000000000000001,
 r8=0000000000000014,  r9=000000013f520000, r10=0000000000000000,
r11=000000003fc33e80, r12=0000000000000000, r13=000000003fc30630,
r14=000000000a73d180, r15=0000000000000080
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-nncckn\libraries\stackwalker\stackwalker.cpp (906): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-nncckn\src\util\logger.cpp (328): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-nncckn\src\util\logger.cpp (382): Logger::logStacktrace
c:\cygwin64\tmp\factorio-nncckn\src\util\crashhandler.cpp (105): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-nncckn\src\util\crashhandler.cpp (155): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076CDBC00)
0000000076CDBC00 (kernel32): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076EDFF88)
0000000076EDFF88 (ntdll): (filename not available): EtwEventSetInformation
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076E778C8)
0000000076E778C8 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076E87E8D)
0000000076E87E8D (ntdll): (filename not available): RtlDecodePointer
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076E784CF)
0000000076E784CF (ntdll): (filename not available): RtlUnwindEx
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076EABAC8)
0000000076EABAC8 (ntdll): (filename not available): KiUserExceptionDispatcher
c:\cygwin64\tmp\factorio-nncckn\src\graphics\drawqueue.cpp (250): DrawQueue::draw
c:\cygwin64\tmp\factorio-nncckn\src\entity\enemyspawner.cpp (86): EnemySpawner::draw
c:\cygwin64\tmp\factorio-nncckn\src\graphics\entityrenderer.cpp (211): EntityRenderer::prepareRow
c:\cygwin64\tmp\factorio-nncckn\src\graphics\entityrenderer.cpp (162): EntityRenderer::threadJob
c:\cygwin64\tmp\factorio-nncckn\src\util\workerthread.cpp (33): WorkerThread::loop
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 000000013FF49583)
000000013FF49583 (factorio0): (filename not available): boost::thread::start_thread_noexcept
d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076C559BD)
0000000076C559BD (kernel32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000076E8A2E1)
0000000076E8A2E1 (ntdll): (filename not available): RtlUserThreadStart
  16.252 Error CrashHandler.cpp:106: Map tick at moment of crash: 37661
  16.252 Error Util.cpp:77: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

to reproduce, use this mod and map :

crash-arma.zip

(1.76 MiB) Downloaded 126 times

unzoom to max (important!)
then walk to the upper-left and follow the shore to the north. Then it should soon crash.

I did not understood what could trigger this. But it is coming from my armageddon mod. You will see that in the mod, for finding the crash origin, I disabled all events, but it still crash : so I do not understand...

[posila]

Hi, thanks for the report.
Have you changed number of animation variations of arma-spawner befor this started to happen?

[binbinhfr]

Hi, thanks for the report.
Have you changed number of animation variations of arma-spawner befor this started to happen?

Yes I played with this and made several tests just yesterday before it happens. Basically I use a single-frame animation, so put it down to 1.

[posila]

In that case, thanks for the report. Fixed for 0.13.18

Problem was spawners have saved animation variation index, but it was not checked for validity on load. When number of variations is reduced, it will eventually result in out of bounds read from animation array and that will cause the crash.

[binbinhfr]

OK, nice you found the problem.

But does it mean that my mod will crash on every client until 0.13.18 ?
If I revert to old animations, will it still crash because of corrupted save ? I hope I did not corrupt players saves...

[posila]

Luckily, saves won't be corrupted. And if it did corrupt them, it would not be your fault

It will crash for people that have played previous version of your mod on their saves.
If you revert to old animations, it won't crash.

[binbinhfr]

Luckily, saves won't be corrupted. And if it did corrupt them, it would not be your fault

It will crash for people that have played previous version of your mod on their saves.
If you revert to old animations, it won't crash.

Thats' what I was afraid of.
already 24 people downloaded the new version.
I will publish a temporary revert (unless you tell me that 0.13.18 will go out in a few hours...)

[posila]

unless you tell me that 0.13.18 will go out in a few hours...

I don't think it will, sorry

[binbinhfr]

OK. To avoid problems with users and useless bug reports, I just published a corrected version, that effectively does not crash...
thx for your help.