[0.12.30] [kovarex] Crash when clearing modded blueprint item

[Lilly]

Description:
Clearing a blueprint item that doesn't have 'item_to_clear' set, crashes the game.

Expected result:
Any of the following:

• Display a message stating that the blueprint cannot be cleared.
• Clear the blueprint without using an item.
• Throw an error stating that 'item_to_clear' is not set while loading the mod

It would be nice if modders can specify that a blueprint item cannot be cleared or specify that clearing doesn't use any items.

Reproduction scenario:

1. Install the attached mod.
2. Start a new game (the mod will provide some additional starting items, including the 'broken blueprint' item).
3. Place an object (for example, a wooden-chest or burner-inserter).
4. Use the 'broken blueprint' item (signal B icon) to create a blueprint.
5. Try to clear the blueprint by right-clicking it. This crashes the game.

Stacktrace:

Code: Select all

#0  0x7fedc62282f0 in ?? at ??:0
#1  0xdfed68 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) at ??:?
#2  0x52622c in LocalisedString::LocalisedString(LocalisedString const&) at /usr/include/c++/5/bits/stl_vector.h:655
#3  0x547a59 in std::vector<LocalisedString, std::allocator<LocalisedString> >::vector(std::vector<LocalisedString, std::allocator<LocalisedString> > const&) at /usr/include/c++/5/bits/stl_vector.h:320
#4  0x547cbe in LocalisedString::LocalisedString(LocalisedString const&) at /tmp/factorio-muYlK6/src/Util/LocalisedString.hpp:14
#5  0x99c212 in void std::vector<LocalisedString, std::allocator<LocalisedString> >::_M_emplace_back_aux<LocalisedString const&>(LocalisedString const&) at /usr/include/c++/5/ext/new_allocator.h:120
#6  0x78d329 in _S_construct<LocalisedString, const LocalisedString&> at /usr/include/c++/5/bits/alloc_traits.h:256
#7  0x6d427c in construct<LocalisedString, const LocalisedString&> at /usr/include/c++/5/bits/alloc_traits.h:402
#8  0xa46ff5 in _M_emplace_back_aux<const LocalisedString&> at /usr/include/c++/5/bits/vector.tcc:416
#9  0x6d3488 in LocalisedString::LocalisedString(std::string const&, LocalisedString const&) at /tmp/factorio-muYlK6/src/Util/LocalisedString.cpp:122
#10 0x7523b4 in GameActionHandler::clearBlueprint(InputAction const&, Controller*) at /tmp/factorio-muYlK6/src/GameActionHandler.cpp:739 (discriminator 4)
#11 0xd5851f in GameActionHandler::actionPerformed(InputAction const&) at /tmp/factorio-muYlK6/src/GameActionHandler.cpp:206 (discriminator 4)
#12 0x7fedc7d876aa in InputHandler::flushActions(bool) at /tmp/factorio-muYlK6/src/Input/InputHandler.cpp:41
#13 0x7fedc62f9e9d in flushActions at /tmp/factorio-muYlK6/src/Input/InputHandler.cpp:34

Workaround:
Specify an unobtainable dummy item as 'item_to_clear' and use 'to know that it's impossible' as the item's name. When trying to clear such a blueprint it gives the message: "You need to know that it's impossible to clear this blueprint.".

[Klonan]

Thank you for the report

Can reproduce, with the provided mod,
https://gfycat.com/UnacceptableIdealisticHornedtoad

The item_to_clear node doesn't exist

Crash report

Code: Select all

   0.000 2016-04-21 17:34:28; Factorio 0.12.29 (Build 17931, win64, steam)
   0.001 Operating system: Windows 10 
   0.001 Program arguments: "C:\Program Files (x86)\Steam\steamapps\common\Factorio\bin\x64\Factorio.exe" 
   0.001 Read data path: C:/Program Files (x86)/Steam/steamapps/common/Factorio/data
   0.001 Write data path: C:/Users/konra/AppData/Roaming/Factorio
   0.001 Binaries path: C:/Program Files (x86)/Steam/steamapps/common/Factorio/bin
   0.017 Graphics options: [FullScreen: true] [VSync: true] [UIScale: 140%] [MultiSampling: X 2] [Graphics quality: normal] [Video memory usage: high] [Light scale: 80%] [Screen: 0]
   0.017 Available display adapters: 2
   0.018  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 660   {0x05, [0,0], 1920x1200, 32bit, 59Hz}
   0.018  [1]: \\.\DISPLAY2 - NVIDIA GeForce GTX 660   {0x01, [1920,0], 1920x1200, 32bit, 59Hz}
   0.018 Create display on adapter 0. Size 1280x720 at position [310, 222].
   0.085 Initialised Direct3D:[0] NVIDIA GeForce GTX 660  ; driver: nvd3dumx.dll 10.18.13.5891
   0.108 Desktop composition is active.
   0.163 Loading mod core 0.0.0 (data.lua)
   0.169 Loading mod base 0.12.29 (data.lua)
   0.390 Loading mod bugmod 0.0.1 (data.lua)
   0.425 Loading mod Combat_Units 0.1.0 (data.lua)
   0.486 Loading mod Spawn_Gear 0.1.4 (data.lua)
   0.890 Initial atlas bitmap size is 16384
   0.891 Created atlas bitmap 16384x5508
   6.495 Sprites loaded
   6.683 Loading sounds...
   8.206 Factorio initialised
  12.089 Loading map C:/Users\konra\AppData\Roaming\Factorio\saves\bugsotya.zip
  12.123 Info Scenario.cpp:124: Map version 0.12.29-0
  51.108 Error CrashHandler.cpp:105: Exception Code: c0000005, Address: 00007FF70C3D5FD4
  51.108 Error CrashHandler.cpp:115: Exception Context:
rax=000001fcb986e890, rbx=0000000000000028, rcx=000001fcb986e890,
rdx=0000000000000028, rsi=000001fcb986e890, rdi=0000000000000028,
rip=00007ff70c3d5fd4, rsp=000000f58dbff030, rbp=000000f58dbff169,
 r8=0000000000000000,  r9=ffffffffffffffff, r10=0000000000000000,
r11=000001fcb98661b0, r12=0000000000000000, r13=000000f58c98f450,
r14=0000000000000001, r15=000001fcb98bfdc0
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-vbn8ul\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-vbn8ul\src\util\logger.cpp (306): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-vbn8ul\src\util\logger.cpp (360): Logger::logStacktrace
c:\cygwin64\tmp\factorio-vbn8ul\src\util\crashhandler.cpp (84): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-vbn8ul\src\util\crashhandler.cpp (125): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA51397E1E)
00007FFA51397E1E (KERNELBASE): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA545CD998)
00007FFA545CD998 (ntdll): (filename not available): memset
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA545B5B26)
00007FFA545B5B26 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA545C9AED)
00007FFA545C9AED (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA54554FE9)
00007FFA54554FE9 (ntdll): (filename not available): RtlImageNtHeaderEx
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA545C8BFA)
00007FFA545C8BFA (ntdll): (filename not available): KiUserExceptionDispatcher
c:\program files (x86)\microsoft visual studio 12.0\vc\include\xstring (1130): std::basic_string<char,std::char_traits<char>,std::allocator<char> >::assign
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF70C36ACF2)
00007FF70C36ACF2 (Factorio): (filename not available): LocalisedString::LocalisedString
c:\program files (x86)\microsoft visual studio 12.0\vc\include\vector (882): std::vector<LocalisedString,std::allocator<LocalisedString> >::push_back
c:\cygwin64\tmp\factorio-vbn8ul\src\gameactionhandler.cpp (736): GameActionHandler::clearBlueprint
c:\cygwin64\tmp\factorio-vbn8ul\src\gameactionhandler.cpp (207): GameActionHandler::actionPerformed
c:\cygwin64\tmp\factorio-vbn8ul\src\input\inputhandler.cpp (39): InputHandler::flushToListeners
c:\cygwin64\tmp\factorio-vbn8ul\src\input\inputhandler.cpp (33): InputHandler::flushActions
c:\cygwin64\tmp\factorio-vbn8ul\src\gameactionhandler.cpp (246): GameActionHandler::update
c:\cygwin64\tmp\factorio-vbn8ul\src\mainloop.cpp (256): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-vbn8ul\src\mainloop.cpp (369): MainLoop::updateLoop
c:\boost_1_58_0\boost\function\function_template.hpp (160): boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void,void (__cdecl*)(ThreadBarrier * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,bool * __ptr64,bool),boost::_bi::list5<boost::_bi::value<ThreadBarrier * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<bool * __ptr64>,boost::_bi::value<bool> > >,void>::invoke
c:\cygwin64\tmp\factorio-vbn8ul\src\util\thread.cpp (34): Thread::loop
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF70C56F883)
00007FF70C56F883 (Factorio): (filename not available): boost::`anonymous namespace'::thread_start_function
f:\dd\vctools\crt\crtw32\startup\threadex.c (376): _callthreadstartex
f:\dd\vctools\crt\crtw32\startup\threadex.c (354): _threadstartex
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA51A58102)
00007FFA51A58102 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA5457C5B4)
00007FFA5457C5B4 (ntdll): (filename not available): RtlUserThreadStart
  52.187 Error Util.cpp:78: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

[kovarex]

Fixed for 0.12.31