[0.12.30] [kovarex] wrong menu after load error while in game

[prg]

Use a mod that breaks loading games, like with

Code: Select all

script.on_load(function()
    breakme()
end)

Save a game and load it again from the main menu. You get the expected error message. Clicking "back" in the "load game" dialog gets you back to the right menu. No problem.

Now start a new game and while still in game load the broken save. Dismiss the error message, click "back" in the "load game" dialog. You're now looking at the in game menu in front of the main menu background. Clicking "resume" takes you to the main menu. Clicking instead "restart -> ok", "save game" or "quit game" crashes Factorio.

crash when clicking save game

Code: Select all

   0.000 2016-04-06 20:46:44; Factorio 0.12.30 (Build 17998, linux64, alpha)
   0.000 Operating system: Linux
   0.000 Program arguments: "./factorio" 
   0.000 Read data path: /home/prg/Downloads/factorio/data
   0.000 Write data path: /home/prg/Downloads/factorio
   0.000 Binaries path: /home/prg/Downloads/factorio/bin
   0.011 Graphics options: [FullScreen: false] [VSync: false] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Light scale: 100%] [Screen: 0]
   0.054 Available display adapters: 3
   0.054  [0]: resolution 1280x1024px at [1280,0]
   0.054  [1]: resolution 1024x768px at [2560,0]
   0.054  [2]: resolution 1280x1024px at [0,0]
   0.054 Create display on adapter 0. Size 1280x720 at position [0, 134].
   0.140 Initialised OpenGL:[0] GeForce GTX 660/PCIe/SSE2; driver: 4.5.0 NVIDIA 361.28
   0.187 Loading mod core 0.0.0 (data.lua)
   0.189 Loading mod base 0.12.30 (data.lua)
   0.228 Checksum for core: 3711505753
   0.228 Checksum for mod base: 2829195351
   0.228 Checksum for mod bla: 0
   0.461 Initial atlas bitmap size is 16384
   0.464 Created atlas bitmap 16384x7764
   4.692 Sprites loaded
   4.693 Loading sounds...
   5.898 Factorio initialised
  12.868 Info Scenario.cpp:124: Map version 0.12.30-0
  12.888 Checksum for script /home/prg/Downloads/factorio/temp/currently-playing/control.lua: 393467729
  12.889 Checksum for script __bla__/control.lua: 1414565876
  16.028 Loading map /home/prg/Downloads/factorio/saves/bla_01.zip
  16.037 Info Scenario.cpp:124: Map version 0.12.30-0
  16.060 Checksum for script /home/prg/Downloads/factorio/temp/currently-playing/control.lua: 393467729
  16.060 Checksum for script __bla__/control.lua: 1414565876
  19.324 Warning Logger.cpp:338: Symbols.size() == 19, usedSize == 13
Factorio crashed. Generating symbolized stacktrace, please wait ...
  19.785 Warning Logger.cpp:338: Symbols.size() == 18, usedSize == 12
#0  0x7fe9ba2e22f0 in ?? at ??:0
#1  0xd07b93 in boost::filesystem::detail::status(boost::filesystem::path const&, boost::system::error_code*) at crtstuff.c:?
#2  0x4a11d6 in isSubdirCanonical(boost::filesystem::path const&, boost::filesystem::path const&) at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/filesystem/operations.hpp:285
#3  0x9d8939 in exists at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/filesystem/operations.hpp:404
#4  0x9d8e6e in isSubdirCanonical at /tmp/factorio-muYlK6/src/Util/FileUtil.cpp:173
#5  0x574370 in SaveGameAsGui::SaveGameAsGui(boost::filesystem::path const&, boost::filesystem::path const&) at /tmp/factorio-muYlK6/src/Gui/SaveGameAsGui.cpp:43
#6  0xa2889e in InSaveGameAsDialog::enableGui() at /tmp/factorio-muYlK6/src/AppManagerStates.cpp:792 (discriminator 2)
#7  0xa3ee04 in AppManager::changeStateInternal() at /tmp/factorio-muYlK6/src/AppManager.cpp:289
#8  0xa48c65 in AppManager::pushState(AppManagerState*) at /tmp/factorio-muYlK6/src/AppManager.cpp:237
#9  0xa9e8dd in InGameMenu::process(AppManager*) at /tmp/factorio-muYlK6/src/AppManagerStates.cpp:225
#10 0x7fe9ba2cf7b0 in MainLoop::run(boost::filesystem::path const&, boost::filesystem::path const&, bool, bool, std::string const&) [clone .constprop.51866] at /usr/include/c++/5/bits/stl_vector.h:655
#11 0x40a379 in size at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/ptr_container/detail/reversible_ptr_container.hpp:511
  19.785 Error Util.cpp:78: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

[kovarex]

Thanks for the report, it is fixed for 0.12.31 now.