[0.12.12] [kovarex] Save and Autosave crash

[MakiabelMFE]

Fixed, for now

Hi, I've been having this bug for about an hour and I can't really find an indication as to what exactly is going on.

What happens: Game crashes when trying to load a save after I die on the current game. (Not trying to load the same save, using alternative autosave and personal backup save).

How to reproduce: It seems to be every time you die on a map, then try to load a different save from the same map.

How often it happens: Also seems to be always.

I'm currently using Bob's Mods and a few other mods, all tested though, none throw any issues.

I attach the save of the map itself, and the log of the crash.

https://www.dropbox.com/s/r6j9qhj2ine2d ... h.zip?dl=0
http://pastebin.com/c33M1fJR

Alright, after some time checking everything again, apparently every mod wasn't working perfectly, after some trial and error Natural Evolution among other mods were causing the game to crash after loading the save. As soon as I disabled them all saves are working perfectly.
Sorry to bother!
I'm not entirely sure as if this is a game mechanic and I just misunderstood something, but I thought that even though you might die you can always load back from a back up save.

Anyway, looking forward to hearing back about it! Thank you for taking the time to read!.

[waduk]

Have similar issue with different mod, it's mod problem due 0.12.11+ changes, crashing a on loading from newly saved file, you didn't have to die to test this.
Just save the file manually then re-load it, if it crash then it's not game-mechanic/autosave related bug, isn't it ?
Obviously if you want to test it, don't overwrite your current save file !

[Adil]

Mine happens during loading saves.
A mod named commandcontrol causes it.

crashlog

0.000 2015-10-21 17:35:54; Factorio 0.12.12 (Build 17122, linux64)
0.000 Operating system: Linux
0.000 Program arguments: "/home/d/Programs/f/factorio/bin/x64/factorio"
0.000 Read data path: /home/d/Programs/f/factorio/data
0.000 Write data path: /home/d/Programs/f/factorio
0.000 Binaries path: /home/d/Programs/f/factorio/bin
0.012 Available display adapters: 1
0.012 [0]: resolution 1366x768px at [0,0]
0.012 Create display on adapter 0. Size 1266x668 at position [40, 32]. Monitor 0
0.042 Initialised OpenGL:[0] Mesa DRI Intel(R) Haswell Mobile ; driver: 3.0 Mesa 10.1.3
0.073 Graphics options: [FullScreen: false] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Screen: 255]
0.151 Loading mod core 0.0.0 (data.lua)
0.153 Loading mod base 0.12.12 (data.lua)
0.202 Loading mod Aircraft 1.0.0 (data.lua)
0.240 Loading mod commandcontrol 1.1.2 (data.lua)
0.696 Initial atlas bitmap size is 8192
0.714 Created atlas bitmap 8192x8185
0.715 Created atlas bitmap 8192x7134
9.298 Info Updater.cpp:720: Downloading https://www.factorio.com/updater/get-av ... iVersion=2
10.358 0 packages available to download (experimental updates enabled).
10.400 Factorio initialised
14.429 Loading map /home/d/Programs/f/factorio/saves/12.zip
14.448 Info Scenario.cpp:123: Map version 0.12.11-2
Factorio crashed. Generating symbolized stacktrace, please wait ...
#0 0x833379 in CrashHandler::SignalHandler(int) at /tmp/factorio-7jJxxA/src/Util/CrashHandler.cpp:141
#1 0x7f149fa15d40 in ?? at ??:0
#2 0x7f149fa15cc9 in ?? at ??:0
#3 0x7f149fa190d8 in ?? at ??:0
#4 0xd448dd in __gnu_cxx::__verbose_terminate_handler() at ??:?
16.890 Error Util.cpp:61: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.
Factorio crashed. Generating symbolized stacktrace, please wait ...

The code which might be related is

code

Code: Select all

local function Migration_1_1_2()
	if global.radar_system and not global.radar_system.ranges then 
		global.radar_system.ranges={["radar"]=3*32}
	end
end
script.on_configuration_changed(Migration_1_1_2)

Code: Select all

function RadarSystem:OnLoad()
	self.enabled = true
	
	if not self.filtered_radars then
		self.filtered_radars = {}
	end
	if not self.search_term then
		self.search_term = {}
	end
	if not self.visit_count then
		self.visit_count = {}
	end

	-- remove invalid radars.
	for i = #self.radars, 1, -1 do
		local radar = self.radars[i]
		if not radar.valid then
			table.remove(self.radars, i)
		end
	end

	StartCoroutine(self.UpdateGUIRoutine, self)
end

local function OnGameLoad()
	if not mod_has_init and global.radar_system then
		global.radar_system = RadarSystem.CreateActor(global.radar_system)
		global.radar_system:OnLoad()
		mod_has_init = true
	end
end
script.on_load(OnGameLoad)

[Adil]

Natural Evolution among other mods

Is natural evolution even updated to 12.11? Could you list other mods that are causing this?

Edit: whoops, doublepost? Doublepost!
I'v modified the mod code to see which action caused the crash and got zero results:

code

Code: Select all

script.on_load(function() print('on_l') OnGameLoad() print('oad'))
script.on_configuration_changed(function() print('Migrating'); Migration_1_1_2(); print('Migrated') end)

The stdoutput didn't have any of those added messages:

Log

0.000 2015-10-21 17:54:31; Factorio 0.12.12 (Build 17122, linux64)
0.000 Operating system: Linux
0.000 Program arguments: "./factorio"
0.000 Read data path: /home/d/Programs/f/factorio/data
0.000 Write data path: /home/d/Programs/f/factorio
0.000 Binaries path: /home/d/Programs/f/factorio/bin
0.012 Available display adapters: 1
0.012 [0]: resolution 1366x768px at [0,0]
0.012 Create display on adapter 0. Size 1266x668 at position [40, 32]. Monitor 0
0.051 Initialised OpenGL:[0] Mesa DRI Intel(R) Haswell Mobile ; driver: 3.0 Mesa 10.1.3
0.086 Graphics options: [FullScreen: false] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Screen: 255]
0.172 Loading mod core 0.0.0 (data.lua)
0.174 Loading mod base 0.12.12 (data.lua)
0.227 Loading mod Aircraft 1.0.0 (data.lua)
0.268 Loading mod commandcontrol 1.1.2 (data.lua)
0.743 Initial atlas bitmap size is 8192
0.761 Created atlas bitmap 8192x8185
0.763 Created atlas bitmap 8192x7134
9.413 Info Updater.cpp:720: Downloading https://www.factorio.com/updater/get-av ... iVersion=2
10.656 0 packages available to download (experimental updates enabled).
10.701 Factorio initialised
13.261 Loading map /home/d/Programs/f/factorio/saves/12.zip
13.281 Info Scenario.cpp:123: Map version 0.12.11-2
terminate called after throwing an instance of 'lua_longjmp*'
terminate called recursively
Factorio crashed. Generating symbolized stacktrace, please wait ...
#0 0x7f15ce6f5d40 in ?? at ??:0
#1 0x7f15ce6f5cc9 in ?? at ??:0
#2 0x7f15ce6f90d8 in ?? at ??:0
#3 0xd448dd in __gnu_cxx::__verbose_terminate_handler() at ??:?
15.844 Error Util.cpp:61: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

Though in this log there's this "terminate called after throwing an instance of 'lua_longjmp*' " line

[waduk]

Natural Evolution among other mods

Is natural evolution even updated to 12.11? Could you list other mods that are causing this?

You're not replying to me, but i'm gonna answer it anyway.

Mine was AutoTrash 0.0.51, but it has been fixed in 0.0.52

[kovarex]

Could you upload the faulty versions of some of the mods? I need to find out why are they crashing the game.

[MakiabelMFE]

...

Hey, thanks for answering!. As far as I've read on Natural Evolution's board, it should be working as I understand. As of right now, all of NE's mods and Autofill, Autotrash (0.0.52 fixed it already though), BigWoodenPowerpole, Command Control, Cyberchest, F-Item Destroyer, FastFilterFill, ForceFields, Guntrains, Personal Roboport Fix and UniqueBacker Names.

Some of these are disabled because they haven't been updated yet. Though, some, as NE's actually load just fine but as soon as it was disabled every save went back to normal. (on top of disabling the already listed others).

So it might be another one, but I'm not sure. Been playing for 2 hours straight already with those mods disabled and no issues at all, can save and load just fine.

Could you upload the faulty versions of some of the mods? I need to find out why are they crashing the game.

Sure!, I'll do that asap, I'll edit this comment when I got them all.

Alright here's a .zip with the mods I have disabled, as of right now, everything running smoothly. (Besides waiting on some localised.name updates for other mods but no issues still)

Zip Link

https://www.dropbox.com/s/lblhqk8bv3z94 ... o.zip?dl=0

[Choumiko]

Could you upload the faulty versions of some of the mods? I need to find out why are they crashing the game.

As for AutoTrash it was https://github.com/Choumiko/AutoTrash/a ... 0.0.51.zip
I did screw up copy/pasting:

Code: Select all

 global["logistics-config"][player.name] = global["logistics-config"] or {}

It's called in on_player_created (global["logistics-config"] is set to {} beforehand). A serpent.dump after starting a new game had something along

Code: Select all

global["logistics-config"].Choumiko = global["logistics-config"]

at the end. Looks like some sort of circular thing could happen when Factorio tries to load that after saving the first time.
Crash log ended before writing a stacktrace.

[Adil]

Aww shoot, there appears to be several touched by me:

commandcontrol_1.1.2.zip

(8.46 KiB) Downloaded 225 times

- there was a clumsy update attempt of a code I don't really understand, can't provide much support. I guess 'll understand if no one will wish to dive into this either.
Unlimited_upgrades_file_was_here - this one was crashing due to pcall bug covered in other thread. (And a bunch of typos during testing ) I guess I'll take it down as unneeded distraction.
Guntrains seem to be working properly though.
Sorry if not informative, got to go.

[kovarex]

Ok, so I found out that this code is enough:

Code: Select all

/c global.table = {}
/c global.table["hello"] = global.table

Once this is saved, it can't be loaded. I will take a look.

[cube]

I think this might be two unrelated bugs at the same time. The stack trace looks suspiciously similar to https://forums.factorio.com/forum/vie ... =7&t=17208 duplicates.

[kovarex]

Ok, so I found out that this code is enough:

Code: Select all

/c global.table = {}
/c global.table["hello"] = global.table

Once this is saved, it can't be loaded. I will take a look.

Thanks for the help, the issue is now fixed, and the above structure is working properly and loadable in 0.12.13

[MakiabelMFE]

Ok, so I found out that this code is enough:

Code: Select all

/c global.table = {}
/c global.table["hello"] = global.table

Once this is saved, it can't be loaded. I will take a look.

Thanks for the help, the issue is now fixed, and the above structure is working properly and loadable in 0.12.13

That's awesome, thanks a lot for the quick response! that was pretty fast!.