[2.1.14] Potential production speed tooltip doesn't update for machine quality-upgrade ghosts

[Eugene_Rymarev]

Hello.
Following up on this thread - it originally described the issue with upgrading a beacon's quality, and was marked as fixed in 2.1.13.

However, on version 2.1.14 the same issue persists when upgrading the quality of the machine itself via a ghost (tested on an electric furnace and an electromagnetic plant, and the same applies to assembling machines). It looks like the 2.1.13 fix only covered the beacon case, not the production buildings themselves.

Steps to reproduce:

1. Place a machine (e.g. an electric furnace) with a recipe set - it's running, and the tooltip shows the current production speed for the product (e.g. 0.25/s for steel beams).
2. Place a ghost of the same machine at a higher quality (quality-upgrade ghost) on top of the existing machine.
3. Hover over the machine with the ghost on it.

Actual result: The tooltip still shows only the current production speed value (0.25/s for the furnace, 0.75/s for the electromagnetic plant). No blue potential production-speed value is shown for the pending quality upgrade.

Expected result: The tooltip should show the potential production speed accounting for the building's own quality-upgrade ghost — the same way it already works for module ghosts and (as of 2.1.13) for beacons.

Attaching 4 screenshots - two before/after pairs (Electric furnace and Electromagnetic plant): in each pair, the first screenshot shows the machine without a ghost, the second shows it with a quality-upgrade ghost added. The tooltip's production speed (0.25/s and 0.75/s respectively) doesn't change.

screenshots

1.jpg (197.8 KiB) Viewed 404 times

2.jpg (215.5 KiB) Viewed 404 times

3.jpg (256.98 KiB) Viewed 404 times

4.jpg (236.46 KiB) Viewed 404 times

[boskid]

I have mixed feelings if i want to consider this to be a bug, original feature was all about module upgrades and it was not intended to cover entity upgrades. It was possible to extend this logic to upgrading beacons, however upgrading entity itself is extremally tricky because of the amount of logic that needs to match between real entities and predicted upgrade result: upgraded entity may accept different effects, upgraded entity may not be an assembler at all, upgraded entity may not accept modules that are currently in the machine, upgraded entity may not accept recipe that is currently crafted, there are cases of assembler upgrading into a furnace or furnace upgrading into assembler, upgraded entity may have different base effects, in some cases upgraded entity could even have a different bounding box making set of beacons that are affecting it to be different. I could do a minimalistic "fix" that would only account for the different crafting speed assuming that everything else is unchanged (same base effect, same effects allowed, same effect sources allowed, same crafting categories) and fallback of not showing predicted values if entity is being upgraded to something that is not a crafting machine (not assembler nor furnace).

[Eugene_Rymarev]

I could do a minimalistic "fix" that would only account for the different crafting speed assuming that everything else is unchanged (same base effect, same effects allowed, same effect sources allowed, same crafting categories) and fallback of not showing predicted values if entity is being upgraded to something that is not a crafting machine (not assembler nor furnace).

I think that within a single entity type (including different tiers of that entity like Assembling Machine 1, 2, and 3), but involving different quality levels, this would be exactly what is needed.

[boskid]

Even including different tiers of assemblers is tricky, for example assembler 2 accepts all effects while assembler 1 does not accept quality nor productivity, so if assembler 2 was downgraded to assembler 1 it would use incorrect effects thinking that modules that are currently in the machine would apply slowing the machine down even if those modules would be ejected after downgrade. Also assembler 1 does not have pipe connections so assembler 2 that is filling barrels when ordered to be downgraded to assembler 1 would be showing barrel filling speed using assembler 1's speed even if the assembler 1 is unable to craft this recipe.

[Eugene_Rymarev]

Even including different tiers of assemblers is tricky, for example assembler 2 accepts all effects while assembler 1 does not accept quality nor productivity, so if assembler 2 was downgraded to assembler 1 it would use incorrect effects thinking that modules that are currently in the machine would apply slowing the machine down even if those modules would be ejected after downgrade. Also assembler 1 does not have pipe connections so assembler 2 that is filling barrels when ordered to be downgraded to assembler 1 would be showing barrel filling speed using assembler 1's speed even if the assembler 1 is unable to craft this recipe.

Agreed, you're right. In that case, you need to limit this to just quality upgrades or downgrades.

[boskid]

Ok, for 2.1.15 i made the recipe crafting speed predictions to account for upgraded quality of the crafting machine.

This is the limit of what i want to do with this feature, if the upgraded machine differs with allowed effects, allowed modules, allowed recipe categories the predicion may be incorrect and i will consider that to be not a bug as it is way outside of what is reasonably possible.