[2.1.11] Train stops blueprints place with wrong colour

This subforum contains all the issues which we already resolved.
kjagodka
Burner Inserter
Burner Inserter
Posts: 15
Joined: Sun Jan 12, 2020 5:20 pm
Contact:

[2.1.11] Train stops blueprints place with wrong colour

Post by kjagodka »

I created blueprint with multiple parameters without setting station colour. In blueprint JSON stop's RGBA values are not set.

When placing blueprint afterwards, before setting parameters to existing coloured station, ghost shows default station colour as expected
Image
After setting parameter to existing coloured station, ghost shows coloured station, matching existing one
Image
After confirming parameters and placing blueprint colour changes back to default.
Image

Expected behavior: Uncoloured stop placed by blueprint should match colour with existing coloured stop with same name.

Uncoloured blueprint


Similar bug was reported in viewtopic.php?p=674864#p674864, but in this case parametrized blueprint already had stop colour set, equal to default collour and bug doesn't occur in 2.0.77 so it's different issue.

Attached are: screenshots if external imgur hosting would stop working after some time
Savegame containing example coloured station and blueprints.
Factorio log file
pics
Attachments
factorio-current.log
log file
(8.53 KiB) Downloaded 33 times
station colors bug.zip
Replication save
(822.91 KiB) Downloaded 39 times
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 4767
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.1.11] Train stops blueprints place with wrong colour

Post by boskid »

Thanks for the report. Issue is now fixed for 2.1.13.

There is a high chance that my fix broke something else because the copy color on rename feature is built on top of weak foundations assuming proper ordering of train stop rename and color copying. Issue was caused by blueprint builder which uses a blueprint copy with all entities under "blueprint" force and this is when the parameters were applied: the train stop got its station name correctly set but the color was not set because "blueprint" force had no train stops. When this blueprint was then placed, the train stop would get station name set, color changed as part of setting station name but then color would get copied from the parametrised blueprint which has no color and as such the color was cleared.
Post Reply

Return to “Resolved Problems and Bugs”