[2.1.7] Fluids in connected storage deleted on recipe change

[MEOWMI]

In the new experimental 2.1.7, fluids are deleted from connected storage if a producer changes recipe.

See attached save for example (look at the fluid storage tank as the recipe automatically resets periodically).

- What did you do?
Clear a recipe by circuit control. In this case, it's the recipe for quantum processors.

- What happened?
All fluid is cleared, everything in the tank (all 10k) and in the electromagnetic plant.

- What did you expect to happen instead? It might be obvious to you, but do it anyway!
Fluid from the plant is cleared (and flushed to the tank), otherwise tanks contents remain as they are (it should not make 10k fluid disappear).

- Does it happen always, once, or sometimes?
Every time (about 20/20 attempts)

[gridstop]

I was just coming to report this. Clearing the recipe on a EM plant flushes the entire pipe extent on both sides for a passthrough.

That is, a EM plant is consuming light oil to make superconductors, with storage tanks on both sides of the through pipe containing light oil. When the recipe clears due to the circuit clearing, it completely flushes both sides including storage tanks. I think this behavior is unique to the new logic around through-pipes. I don't see the behavior on normal inputs of assembly machines.

What I would expect:
The fluid should be pushed out into the pipes if possible (perhaps half to each newly separated pipe extent, though not critical), and only the internal buffer destroyed if there is no room, same as happens on a normal input for an assembly machine.


Demonstration:
Place the BP, wait a few ticks for the fluid network to fill. Delete the one pipe connecting the infinity pipe to the tank. Then turn off the constant combinator to clear the recipe.

Code: Select all

0eNqVlO1u6jAMhu/Fv9OJlPJV6VwJQlVoTRctTXrysQ2h3vucIsqAcM4m/hTHfuy8tnOCvQrYW6k9lCeQtdEOyu0JnGy1UNGmRYdQgvPGihYzL/QbDAykbvATSj6whDMqrL01nWg1ellnvRKU4BqVDzsGqL30Es/5xj/HSoduj5awLJmXQW8cBRkdk0XQrHhZMDhCOef8ZTHEau5Q+YTqZU8ck7XWBN2kYMsJlhOMQSMtXWT04HmCPf8Fe/OcXSTQBfu3mI8ZeH7hE50aSTGq2uOreJfGjt3VffAVQT6MfXPRYrGB0tuADFqLSKiDUA4p3gSfdB7PJ+8YSs4OfUWXIQkuNIuiqaQmt0bSxdzkenEDF3q0VGUTauowXE6qv0Eo0oE8tLEdTVVCm8XPZee38/H/li4ndtwFmjqf1abbSy3OZT4kmGZmth4TpJR355Tu9nt7mraIwUEqj/beelmCe7EeVIp5u17YscoS/oyGELeaKLLrjfXVgYaIzg5BtbRTMOzol9qY1S/kXT2XNzXV65/uNb9dlwRqc1NlApHzCTFPI/jsumSYSX2Qmo6zZ7z8hhcfs3NARfPvadjdtxdQyfbVZ0bGzsTeUWa6LZSzyPDYkU34YMmSk6EzzVjEp6i9OsIQn8cPUjKOw7ZgnC0Z35FNUiT5Xd9sBu80NGORi2W+WRR5sV4Xq/mSD8MXYlrziQ==

[Rseding91]

Thanks for the report. This is now fixed for the next release.