[2.0.47] copy-pasted offshore-pump ghost is missing fluid information

[SWeini]

05-03-2025, 17-44-46.png (402.67 KiB) Viewed 617 times

The left ghost was created using pipette
The right ghost was created using copy&paste (or by undoing a deconstruction)

The issue: In my mod I can't find a way to know which fluid the right ghost will pump
LuaFluidBox.get_locked_fluid(1) returns nil (returns correct fluid for right ghost)
OffshorePumpPrototype.fluid_source_offset is not accessible from control stage (or is it?)

Aside from modding, having consistency and a water icon on top of the ghost is probably the correct behavior.

[boskid]

This is not so obvious to handle as you are trying to make it look like.

Actual bug here is that the manually placed ghost has a fluid filter set - it was supposed to be set when real offshore pump is placed (or when a ghost is revived). There is however a tiny simplification in the code where ghost is temporarily setup due to buildability checks as an offshore pump built manually goes through fluid mixing checks (entities from blueprint are not checked against fluid mixing). As part of this buildability check, the filter is set but it is not cleared after buildability check and so there is that leftover icon set on the offshore pump. A fix for this would be quite simple: offshore pump would reset fluid filter when destroyed, but that would make both offshore pumps not have filters which i see is against your expectations.

[Rseding91]

This is now fixed for the next release.

[SWeini]

This is now fixed for the next release.

Thanks a lot for fixing. Regarding OffshorePumpPrototype.fluid_source_offset, was I just blind or is this really missing from runtime stage API?

[boskid]

Regarding OffshorePumpPrototype.fluid_source_offset, was I just blind or is this really missing from runtime stage API?

For 2.0.48 i added LuaEntityPrototype::fluid_source_offset read.