[boskid][2.0.41] proxy-container targetting the module inventory of mining-drills don't stay connected when the inv empt

This subforum contains all the issues which we already resolved.
LeonSkills
Inserter
Inserter
Posts: 26
Joined: Mon Feb 11, 2019 12:37 pm
Contact:

[boskid][2.0.41] proxy-container targetting the module inventory of mining-drills don't stay connected when the inv empt

Post by LeonSkills »

Very nitpicky.
I'm making a mod where inserters can interact with any inventory of an entity, including the module inventory. Using the new proxy-container.

This works well with all inventories I've tested (so far), except the module inventory of mining drills.
They stop working once the module inventory has been emptied.

Unexpected behaviour on the top left mining drill:

Image

The logic in the gif for rotating an inserter is that it destroys the current container and creates a new one, connecting to the entity underneath it if possible.

The inserter taking the modules out of mining drill activates when the proxy-container has just been created or when the proxy-container putting the modules back in was just created, but stops working if the module inventory is emptied/empty and gets some items later. Only works again once a proxy-container interacting with the mining drill has been recreated.
Edit: They also reactive on_load

The inserter on the top right mining drill happily continues working when there are modules available, but stops once the inventory was empty at some point in time.

Expected behaviour is seen on the bottom where it's interacting with the module inventory of an assembling machine. Where the inserters keep working.
Even when the inventory empties in the bottom left assembling machine.
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 3645
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.41] proxy-containers targetting the module inventory of mining-drills don't stay connected when the inv empties

Post by boskid »

Thanks for the report, issue is now fixed for 2.0.42.

Issue is completly different to what is included in the topic: it is about mining drill having a wakeup list that was not notified when modules are inserted because the wakeup list was originally only intended to be used by burner drills and fuel inventory. Issue is fixed by having this wakeup list also notified when modules are changed. In the faulty case, if you would use show-wakeup-lists debug option you would notice that inserter is registered sleeping on the mining drill and is never woken up.
Post Reply

Return to “Resolved Problems and Bugs”