[posila] [2.0.23] Crash when thruster plume is nil (SpacePlatform::draw)

[RockPaperKatana]

How to reproduce:
1. Create an empty mod and add

Code: Select all

data.raw.thruster.thruster.plumes = nil

2. Place down a thruster in space
3. Game crashes.

Log:

Code: Select all

287.322 Error CrashHandler.cpp:503: Exception Code: c0000005, Address: 0x00007ff712d809cf
ModuleBase: 0x00007ff711fa0000, ImageSize: 02857000, RelativeAddress: 00de09cf
 287.322 Error CrashHandler.cpp:509: Access Violation: Read at address 0000000000000008
 287.322 Error CrashHandler.cpp:523: Exception Context:
rax=00000231fc81fbf0, rbx=00000231ee1aee90, rcx=0000000000000000,
rdx=ef7bdef7bdef7bdf, rsi=00000231cfffa5f0, rdi=0000000000000000,
rip=00007ff712d809cf, rsp=0000005bd1fff740, rbp=0000005bd1fff7b9,
 r8=00000000000000ff,  r9=00000000000000ff, r10=0000000000001927,
r11=0000005bd1fff6c0, r12=0000023306415980, r13=00000232d9b3b6e0,
r14=00000000ffffda00, r15=0000023192c3bc70
 287.322 Crashed in E:\Games\Factorio\Factorio_2_modding\bin\x64\factorio.exe (0x00007ff711fa0000 - 0x00007ff7147f7000)
Factorio crashed. Generating symbolized stacktrace, please wait ...
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\libraries\StackWalker\StackWalker.cpp(924): StackWalker::ShowCallstack
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Util\Logger.cpp(337): Logger::writeStacktrace
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Util\Logger.cpp(379): Logger::logStacktrace
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Util\CrashHandler.cpp(183): CrashHandler::writeStackTrace
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Util\CrashHandler.cpp(552): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF80151DDA7)
00007FF80151DDA7 (KERNELBASE): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF803DB54B0)
00007FF803DB54B0 (ntdll): (filename not available): memset
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF803D9C886)
00007FF803D9C886 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF803DB23AF)
00007FF803DB23AF (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF803D614B4)
00007FF803D614B4 (ntdll): (filename not available): RtlRaiseException
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF803DB0EBE)
00007FF803DB0EBE (ntdll): (filename not available): KiUserExceptionDispatcher
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Space\SpacePlatform.cpp(962): SpacePlatform::draw
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Graphics\EntityRenderer.cpp(291): `EntityRenderer::threadJob'::`2'::<lambda_1>::operator()
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Graphics\EntityRenderer.cpp(302): EntityRenderer::threadJob
C:\Users\build\AppData\Local\Temp\factorio-build-fPbLB3\src\Util\WorkerThread.cpp(71): WorkerThread::loop
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\thread(56): std::thread::_Invoke<std::tuple<void (__cdecl PackagePathAdapter::*)(void),PackagePathAdapter *>,0,1>
minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(97): thread_start<unsigned int (__cdecl*)(void *),1>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF802CB7614)
00007FF802CB7614 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF803D626B1)
00007FF803D626B1 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
 289.593 Error CrashHandler.cpp:190: Map tick at moment of crash: 17639
 289.649 Info CrashHandler.cpp:318: Executable CRC: 2743255075
 289.649 Error Util.cpp:95: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
 294.639 Uploading log file
 294.663 Error CrashHandler.cpp:270: Heap validation: success.
 294.663 Creating crash dump.
 294.872 CrashDump success

I think setting plumes to nil should be allowed because of this error message, when I set plumes to {}:

11-29-2024, 22-46-59.png (67.63 KiB) Viewed 464 times

[posila]

Thanks for the report.
(The crash is) Fixed for 2.0.24.

[RockPaperKatana]

29 minutes, that's one speedy fix