[Kovarex] [2.0.17] Pipetting parameter signal for a recipe into ingredient parameter inserts recycling recipe

[LCStark]

I wanted to see if you can pipette-paste signals for recipe ingredient parameters instead of having to manually open and select #0 signal for each one of them. Pipetting correctly picks up the #0 recipe parameter signal, putting it into other parameter's values correctly puts the #0 recipe signal, but pasting it into the "Ingredient of" field results in the recycling recipe for parameter #0 being pasted.

11-14-2024, 14-14-27.png (44.45 KiB) Viewed 654 times

There's also a related thing here, though it might be a separate bug, namely that pressing Q over the "Ingredient of:" signal doesn't pick it up with a pipette, so we can't manually set one parameter and pipette it over to the rest.


The #0 signal is only used on assembler recipes (with separate qualities set) and splitter filters, the rest are set as requests on the chests (again with quality set).

11-14-2024, 14-19-00.png (11.45 KiB) Viewed 654 times

11-14-2024, 14-15-24.png (14.32 KiB) Viewed 654 times

I wanted to see if maybe the recycler was doing something weird with the blueprint, but a minimal reproduction without a recycler still does the same:

11-14-2024, 14-24-06.png (85.62 KiB) Viewed 654 times

If the blueprint doesn't have the splitter filter, it doesn't let me pipette the #0 signal at all:

11-14-2024, 14-24-49.png (187.18 KiB) Viewed 654 times

To sum up, I think the bug here is actually two issues:
1. You can't pipette recipe parameter signals.
2. You can pipette non-recipe signals & paste them as "ingredient of", which turns the item-signal into a recipe signal by finding the only recipe available for all items - the recycling with 25% chance of returning same item.

Best case scenario, I'd expect recipe signal pipetting to work and properly selecting the #0 recipe signal in the ingredients.

If that limitation is on purpose (or should be suggested as an addition in "Ideas and suggestions"), then I'd expect we shouldn't be able to paste the pipetted item signal as an ingredient, since the result will always be invalid and not let us save the blueprint with such parameters.

Also, I know I shouldn't put quality modules on legendary item crafter, I've noticed it after recording this video. And yeah, I didn't add the values yet.

[kovarex]

Ok, so by investigating this bug report, I fixed 3 different things.
1) The game was generating self-recycling recipes for parameters (which is nonsense and was removed)
2) Normally you can't select a signal item which is type of item which isn't in the inventory (to avoid confusion, as you wouldn't know if you actually hold the item, or the signal, and also for UI/expectations clarity). But for parameter item, which is never (should be) a physical item in cursor, I made an exception, and it is now pipettable.
3) Logic + added checking code to be able to click existing signal in cursor into the dependency slot to make it actually work.

[LCStark]

Amazing, thank you!