[boskid][2.0.20] Different inserter stack sizes replaced by 1 in parametrised blueprint (size/changed/parameter) (MR)

[qoalabear]

Even when they're not selected to be parameters, the different values are all being replaced with a single value.

1. Have at least inserter-capacity-2 researched.
2. Place two inserters.
3. Activate the "Override stack size" checkbox on both.
4. Give them different values for the override (one with "1" and one with "2")
5. Copy the inserters into a blueprint.
6. Open the blueprint parameterization menu. No need to touch anything in the parameterization menu, just confirm and resave the blueprint ([e] twice).

11-13-2024, 18-35-00.png (26.51 KiB) Viewed 471 times

What I expected

Upon pasting the blueprint, the inserters will still have overrides of "1" and "2".

What happened

Upon pasting the blueprint, both inserters have a stack size override of "1". This only happens if the parameterization menu was opened, even if no parameters were set or modified.

0eNqd0M0KgzAMB/B3ybmTWe3QvsoY4kcYYZpKW8ec9N1X3WEHL7JbEvL/EbJA0084WmIPegFqDTvQ1wUc3bnu1xnXA4IGYofWo4UgYt3hC3QabgKQPXnCb2pr5oqnoYmbOhW7tIDRuBgwvNoROZ0TJWAGXSQq0uaJ1lKHlfN1+6gcvWNcBrGz5QE7/Y/ODtAHrt7eQx6HCP2+LCDuug1SF1nmZalylalcFiF8AErvhMU=

Copy blueprint

0eNqd0M0OgjAMB/B36XkS+ZiBvYoxhI/GNEIh2zAi2btb8OCBC/G2Lv3/2nSBuptwtMQezALUDOzAXBdwdOeqW/+46hEMEDu0Hi0EJe8WX2DicFOA7MkTflNbMZc89bV0mljt0grGwUlg4NUW5HSOtIIZTB5poYcnWkstls5XzaN09MZ1kNrZyQE7/o9OD9CHtpbzkMdeoN+VFUiv2yB9SYqsKHSmU50leQgfSXqEww==

Copy blueprint

[qoalabear]

This bug still occurs as of 2.0.20

[sp55aa]

2.0.23 occurs too

[Woggle]

Just encountered this in 2.0.23 trying to parameterize a train station, inserters with override 10 get set to 1 upon placing it. Also cannot successfully set the stack override to be a parameter even though it is listed and the checkbox appears to work, upon saving the parameter is erased/ignored and value hard set to 1 when placing the blueprint.

[sp55aa]

temporary solution:
1. change inserter stack size override to 1, check Parameter, check Formula and set to right stack size override

Code: Select all

0eNptkE2OgzAMhe/idVoVRKqSq4xGKIBbWQUnys9oKOLudUo7q9n5Wfb7nr1CP2X0gTiBWYEGxxHM1wqRbmyn0mM7Ixjo83Q/EEcMCQNsCohH/AVTbd8KkBMlwn31JZaO89zLpKnU/xYKvIuy5bhQxOlQ6aNWsJSqPmpBjBRw2CcuCtwPhkAjdjHZ4d5FeuAb720QgpjuAdLiC+4dQH0KA5WIqwtznqwoLWpEj3JHuT6FjMWMEs4l7N9fFAg4vlLoc902baubtr6cm9O2PQEfhmov

be careful: if there are other parameters of 1, it may cause mistake

[boskid]

Thanks for the report. This issue is now fixed for 2.0.24. Issue was tightly related to how inserters store the stack size override: there are multiple safeguards to make it not possible to have stack size override higher than value based on force modifiers as this value was directly used as the stack size limit by the inserter's logic. When doing parametrization inside of a blueprint, entities in a blueprint belong to a blueprint (neutral) force and since usually neutral force has no technologies unlocked, just by doing a "no-op" parametrization, as it was performed under neutral force the value was clamped to 1. For 2.0.24 i made the override stack size value to be decoupled from the active stack size which also means i was able to completly get rid of this clamp behavior on the stack size field: it will be now possible to configure inserters ahead of time with a stack size override larger than current force limit, but if it is larger than a value based on force's inserter bonuses would allow it will get allowed (aka not possible to increase hand stack size by using override stack size).