[boskid] [2.0.19] Inserter not resuming after parameterized blueprint changes circuit condition

[Xifon]

The parameterized blueprint I use for my mall has three inputs: recipe, target count in chest, and seconds for which to buffer inputs. It does some magic and configures the requests and inserter. For the sake of this bug report, it's a blueprint that sets a circuit condition on the inserter.

The bug: placing the same blueprint on top of the existing setup with identical settings except a higher target count, causes the inserter to stay frozen as if the original condition is still there.

What should happen: updating a circuit condition via blueprints should cause the condition to be re-evaluated.

Illustrated: Note how the description is "Disabled by control behavior", but the circuit condition should enable the inserter.

Screenshot_20241113_224001.png (88.43 KiB) Viewed 561 times

I tried to attach the savefile, but it turns out that upon loading it the inserter immediately resumes. Fun times.

Blueprint:

Code: Select all

0eNrNV9tuozAQ/ZXIT+0KWjCYXLT7DSut9q2qkAFDLIGhtkkbVfn3HRtyaULSoI22KyQEtuecmZO5kHeUlC1rJBcaLd4RT2uh0OLpHSleCFqaNUErhhaIKsWqpOSicCuaLrlgLkYbB3GRsTe08DfPDmJCc81Zh2Bf1rFoq4RJOOBskZSuJS2Ymy6Z0shBTa3AqhaGDJCi6QNx0BosPHgCBvBJy7qME7akK15Lcy7lMm25jmEvs8YxEzQpWYYWOS0Vc05PGLOcS6Xjk9gyZuLWsk3NQbcpqRDgc8etNDXiEPNSNVRSbVxA39EG9iV7aSGKOOelZlIZTMUsSifCVh0H7U58WO0dMLAVg33XA0FeWlqCdLAualmBp0fUP+xCa7wC2eHaOCdy473cgFC6Ja2aAa1nI7TeKQxCXSuwXjfGhxWXurWBbJ2yJ1y2YnKtIZmKj2L7p2IbrbPrkbNaG5tCMiZGW5maGG0ki2SkjQ257ESGm/cQzCNvOguDKYmiKZliD/uhfYVAzL4XzLFPotk0inAQBR6B+8yPQi/CcCT5/Ag1GTOQLcHOvz6hIRPPlef8KGVuXgL+yBLwfBNRD4gHAPFYQHwAGAwABmMBgwPAcAAwHAsYHgCSAUAyFpCYRuIgLalaxqLW8TYR+nofypp9JDlV2uVCMQnkF1v6zOZMxmWXImgxu7LB28V9Nx7sEGVdcKV5OsZqKDBydWDzo8D+3/45FGfkXJzuF8aF7/W1n/LmdIB1y/FJApoMe4Wf3rSAJ9/B5np27BOBJ9jd4XRdog+fZ/vIf3WUjlk8MzjdD5J+XgZWmp6ql8bZPiyQv+f+2eqm1RNNZcH05M4Wzz1sr6jk5reFI11BXQQkh8HYIpskbZ4zOblT5kMkU0eY3e4hqBXkSAD/LwQwn3EwKjMOCeLW+ZGwnxDjryIOvoo4/Cpi8i+IB0rAM8mVA3JbwicEqujbne80Xsz9bxUXXSE4XZo+wrK+NxmcsYbBhDL9yE6Qywz4DAO+GUNwhiG4GUN4hiG8GQM5w0BGMECb5ZpVprHs/vvB7KQJg5GDfuPJ6+PEpobpQtCJbYqRCM/D+ZyEJCAhnm02fwCldLhZ

Steps to reproduce: place the blueprint above with the recipe set to Gears, and target count 1 (ignore the last field). Let the assembler finish (should take a few seconds at most if iron plates are near). Then, place the same blueprint again but with a higher target count (eg. 5). The circuit conditions are now updated but the inserter does not yet start moving.

[Xifon]

Just happened again on 2.0.19. Noticed on time or I could have lost Gleba!

[boskid]

Thanks for the report. Issue is now fixed for 2.0.20. Issue was that blueprint parametrization was changing circuit condition in a way that was not supposed to be done as it failed to set a flag to reevaluate circuit condition. This issue could easily cause desyncs because this flag was required to be set as the condition is reevaluated after loading so saving-loading would fix the issue and a client in a MP game would desync.