[0.12.19][pos] replay crash in LuaGameScript::pushOnGuiClick

[gheift]

If you start a replay of a save with a mod which adds a GUI and you click on buttons of the GUI during the replay, factorio crashes. My assumption is that mouse click handling in replays is not prevented from firing on_gui_click events in replays.

Code: Select all

./bin/x64/factorio
   0.000 2015-11-26 12:42:59; Factorio 0.12.19 (Build 17459, linux64)
   0.125 Operating system: Linux (Debian stable-updates)
   0.125 Program arguments: "./bin/x64/factorio" 
   0.125 Read data path: /home/gheift/.local/opt/factorio.bug4/data
   0.125 Write data path: /home/gheift/.local/opt/factorio.bug4
   0.126 Binaries path: /home/gheift/.local/opt/factorio.bug4/bin
   0.182 Available display adapters: 1
   0.182  [0]: resolution 1920x1200px at [0,0]
   0.182 Create display on adapter 0. Size 1280x720 at position [310, 222]. Monitor 0
   0.204 Initialised OpenGL:[0] Mesa DRI Intel(R) Ivybridge Desktop ; driver: 3.0 Mesa 11.0.5
   0.230 Graphics options: [FullScreen: false] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Light scale: 20%] [Screen: 0]
   0.254 Loading mod core 0.0.0 (data.lua)
   0.256 Loading mod base 0.12.19 (data.lua)
   0.292 Loading mod test-mode 0.12.11 (data.lua)
   0.326 Loading mod test-mode 0.12.11 (data-updates.lua)
   0.361 Loading mod test-mode 0.12.11 (data-final-fixes.lua)
   0.749 Initial atlas bitmap size is 8192
   0.760 Created atlas bitmap 8192x8191
   0.761 Created atlas bitmap 8192x7185
   6.784 Factorio initialised
  17.066 Warning Logger.cpp:316: Symbols.size() == 21, usedSize == 14
Factorio crashed. Generating symbolized stacktrace, please wait ...
  17.562 Warning Logger.cpp:316: Symbols.size() == 20, usedSize == 13
#0  0x7f6b01af6180 in ?? at ??:0
#1  0x6f95b0 in LuaGameScript::pushOnGuiClick(InputAction const&) at /tmp/factorio-H0YmBR/src/Script/LuaGameScript.cpp:1367
#2  0x6e21af in LuaEventDispatcher::run(unsigned int, unsigned int, boost::function<bool (LuaGameScript*)>) at /tmp/factorio-H0YmBR/src/Script/LuaEventDispatcher.cpp:182
#3  0x6e2500 in LuaEventDispatcher::dispatch(InputAction const&, unsigned int) at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/function/function_template.hpp:881
#4  0x7c2447 in boost::function1<bool, LuaGameScript*>::~function1() at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/function/function_template.hpp:765
#5  0x6e688c in boost::function<bool (LuaGameScript*)>::~function() at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/function/function_template.hpp:1056
#6  0x89a8a3 in dispatch at /tmp/factorio-H0YmBR/src/Script/LuaEventDispatcher.cpp:76
#7  0xa2e399 in LuaContext::actionPerformed(InputAction const&) at /tmp/factorio-H0YmBR/src/Script/LuaContext.cpp:162
#8  0x6e5a98 in InputHandler::flushActions(bool) at /tmp/factorio-H0YmBR/src/Input/InputHandler.cpp:41
#9  0x7e2764 in flushActions at /tmp/factorio-H0YmBR/src/Input/InputHandler.cpp:34
#10 0xd4071f in GameActionHandler::update() [clone .constprop.52695] at /tmp/factorio-H0YmBR/src/GameActionHandler.cpp:251
#11 0x7f6b036900a4 in update at /tmp/factorio-H0YmBR/src/GameActionHandler.cpp:246
#12 0x7f6b01ba706d in MainLoop::updateLoop(ThreadBarrier*, boost::chrono::time_point<boost::chrono::steady_clock, boost::chrono::duration<long, boost::ratio<1l, 1000000000l> > >*, boost::chrono::time_point<boost::chrono::steady_clock, boost::chrono::duration<long, boost::ratio<1l, 1000000000l> > >*, bool*, bool) at /tmp/factorio-H0YmBR/src/MainLoop.cpp:252
  17.562 Error Util.cpp:63: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

[posila]

Thanks for the report. Fixed for next release