Page 1 of 1

Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Fri Mar 08, 2019 1:02 pm
by GotLag
Currently, manually fast-replacing or using the upgrade planner on an inserter results in the upgraded inserter reverting to the prototype's pickup_position and drop_position.

I'd like to suggest that when an inserter is fast-replaced or upgraded, if the prototypes allow custom vectors then the pickup/drop should be carried over, in the same way that circuit conditions are copied.

Naturally I want this for the benefit of Side Inserters, but other mods like Bob's Adjustable Inserters would benefit as well.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Mon Mar 11, 2019 4:22 pm
by mrvn
GotLag wrote: Fri Mar 08, 2019 1:02 pm Currently, manually fast-replacing or using the upgrade planner on an inserter results in the upgraded inserter reverting to the prototype's pickup_position and drop_position.

I'd like to suggest that when an inserter is fast-replaced or upgraded, if the prototypes allow custom vectors then the pickup/drop should be carried over, in the same way that circuit conditions are copied.

Naturally I want this for the benefit of Side Inserters, but other mods like Bob's Adjustable Inserters would benefit as well.
Note: The Upgrade planner mod handled that correctly. So this is a regression with the upgrade planner being added to vanilla.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 10:57 am
by ickputzdirwech
I am 99.9% certain they fixed this issue. Can’t test it in vanilla obviously but it certainly doesn’t exist in Bob’s adjustable inserters anymore.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 10:58 am
by GotLag
You might want to start looking at the dates on these threads before replying.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 10:59 am
by Bilka
ickputzdirwech wrote: Sat Apr 10, 2021 10:57 am I am 99.9% certain they fixed this issue. Can’t test it in vanilla obviously but it certainly doesn’t exist in Bob’s adjustable inserters anymore.
Yes, 65462 / 86982

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 10:59 am
by ickputzdirwech
GotLag wrote: Sat Apr 10, 2021 10:58 am You might want to start looking at the dates on these threads before replying.
I do. Doesn't change that they are implemented.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 11:01 am
by Deadlock989
Well, let us know when you're done personally reorganising 350 pages of forum suggestions from multiple years ago, and then the rest of us can start using the forum again.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 11:01 am
by ickputzdirwech
Already down to 349 :mrgreen:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 1:03 pm
by eradicator
ickputzdirwech wrote: Sat Apr 10, 2021 11:01 am Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 3:00 pm
by ickputzdirwech
As you can read here, ssilk prefers it if you point it out in the thread directly. But I am happy to change the way I do it, if he asks me to.

Don't you get annoyed if you search for something and 10-20% of the results are already implemented or duplicates of one another? True sorting it will take a lot of time, but you will never finish if you don't start.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sat Apr 10, 2021 8:31 pm
by eradicator
ickputzdirwech wrote: Sat Apr 10, 2021 3:00 pm Don't you get annoyed if you search for something and 10-20% of the results are already implemented or duplicates of one another? True sorting it will take a lot of time, but you will never finish if you don't start.
I'm not saying that you should stop doing what you're doing. Infact I think it's a commendable effort. But the way you're doing it disturbs normal forum functionality for everyone else and @ssilk probably just didn't think of that either. Maybe if you make a seperate report thread for it? That way other people can join the effort if they want and if @ssilk subscribes to the thread he automatically gets notified of new entries. And he (or other moderators) could even edit posts to mark which reports have been dealt with.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sun Apr 11, 2021 11:47 am
by ptx0
eradicator wrote: Sat Apr 10, 2021 1:03 pm
ickputzdirwech wrote: Sat Apr 10, 2021 11:01 am Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.
you're not a moderator.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sun Apr 11, 2021 11:56 am
by jodokus31
ptx0 wrote: Sun Apr 11, 2021 11:47 am
eradicator wrote: Sat Apr 10, 2021 1:03 pm
ickputzdirwech wrote: Sat Apr 10, 2021 11:01 am Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.
you're not a moderator.
Does it matter, if the point is good?

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sun Apr 11, 2021 12:03 pm
by ickputzdirwech
ptx0 wrote: Sun Apr 11, 2021 11:47 am
eradicator wrote: Sat Apr 10, 2021 1:03 pm
ickputzdirwech wrote: Sat Apr 10, 2021 11:01 am Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.
you're not a moderator.
No offence taken. A solution is beeing worked on. In the meantime some of you might be interested in reading this topic: 73634.

As you can read there I understand your concerns and I support eradicators idea of a separate report thread.

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sun Apr 11, 2021 1:05 pm
by ssilk
Indeed, I didn’t think of that :oops: , report feature is of course the right way to do it, especially for the older topics. My fault, sorry for inconvinience.

The problem is notified, we are working for it in the background. :)

PS: If we continue to have such great progress we will clear the suggestions-board just within the next 3-4 years. Hopefully Factorio II isn't out at that time, so we can handle all the new suggestions.  🤪 :)

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Posted: Sun Apr 11, 2021 9:02 pm
by eradicator
ickputzdirwech wrote: Sun Apr 11, 2021 12:03 pm No offence taken. A solution is beeing worked on.
Thank you. For the effort, for working on a solution, and especially for not taking offence - a rare trait these days.