Page 1 of 1

Can I public preview for my pull requests?

Posted: Thu Jun 16, 2022 9:03 pm
by Viidi
Hello.

I have made 3 PR:
https://github.com/Yousei9/Logistic-Tra ... k/pull/293
https://github.com/Yousei9/Logistic-Tra ... k/pull/294
https://github.com/Yousei9/Logistic-Tra ... k/pull/295

And I was near to public it as preview, but read license:
- No Modification - Although I can't stop you from looking at my code, you are not allowed to distribute anything altered, or derived from my code without explicit permission first.

Therefore, I explicitly ask for permission to publish a preview of the changes that I made and continue my game with them.

Otherwise, I will be forced to write a similar mod from scratch. Long, painful and sad... )

Re: Can I public preview for my pull requests?

Posted: Fri Jun 17, 2022 6:04 am
by Stringweasel
You can make these changes on locally on your PC and play with the modified LTN, that's fine. As long as you don't publish that to other people, like adding it to the mod portal.

I'm not the creator of LTN though, just some guy. But that's how it typically works.

Re: Can I public preview for my pull requests?

Posted: Fri Jun 17, 2022 10:11 am
by Viidi
Stringweasel wrote: Fri Jun 17, 2022 6:04 am You can make these changes on locally on your PC and play with the modified LTN, that's fine. As long as you don't publish that to other people, like adding it to the mod portal.
Thank you. This is how I debugged my changes )

From time to time I invite a friend to come to my game. It will not be very convenient to send a modified mod.

Re: Can I public preview for my pull requests?

Posted: Fri Jun 17, 2022 1:12 pm
by Optera
Correct, you may play test modifications, but publishing forks is not allowed.
Sorry not opening that can of worms.

Re: Can I public preview for my pull requests?

Posted: Fri Jun 17, 2022 8:12 pm
by Viidi
Optera wrote: Fri Jun 17, 2022 1:12 pm Correct, you may play test modifications, but publishing forks is not allowed.
Sorry not opening that can of worms.
Ok
On the one hand, I want to lay out to make it easier. On the other hand, I agree with your approach. If I do anything worthwhile, I'll probably steal your license :)