Page 1 of 1

[0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Posted: Sat Mar 16, 2019 12:20 am
by FacelessDE
Dear support staff,
Assembly machines can only be rotated once the fluid connection is present. My mod uses heat pipe connections (picture attached), that were rotateable in 0.16. Now in 0.17 it rotates fine while on the cursor, but cannot be changed anymore once placed.
Is this intended or is there a way to rotate an assembler without a fluid pipe?
Regards
Faceless

Image

Code: Select all

Test script:

function on_player_rotated_entity(event)

local entity = event.entity
if not entity.valid then return end

	if entity.name == "assembling-machine-1" then
		--game.print(entity.direction)
		local direction = entity.direction + 2
		if direction > 6 then
		    direction = 0
		end
		entity.direction = direction
		--game.print(direction)
	end
end
	
script.on_event(defines.events.on_player_rotated_entity, on_player_rotated_entity)

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Posted: Tue Apr 02, 2019 12:21 pm
by Bilka
Thank you for the report, fixed for the next version.

Re: [0.17.73] " function on_player_rotated_entity(event)" only works when fluid connection is present

Posted: Thu Oct 24, 2019 7:58 pm
by FacelessDE
Dear support staff,

in Factorio versison 0.17.73 have we my old problem again. I cant rotateabled my assambling machine after build.

Regards

Faceless

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Posted: Thu Oct 24, 2019 8:10 pm
by Bilka
@Whoever solves this: The assembler direction changes, but the heat pipe connection stays in the same place. Test RotateAssemblerWithHeatEnergySource in ManualBuilding suite does not currently check for that.

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Posted: Thu Oct 24, 2019 8:23 pm
by boskid
Heat connector is properly rotated, but adjacent heat pipes are not updated

Re: [0.17.14] " function on_player_rotated_entity(event)" only works when fluid connection is present

Posted: Thu Oct 24, 2019 9:27 pm
by boskid
Thanks. It is now fixed for [0.17.74]

Issue was introduced in [0.17.70] by some mistake. Immediate workaround is to rebuild heat pipes adjacent to previous and new position of heat connection.

-- edit:
btw, this second issue was different and is not related to topic's subject. Next time please make new bug report to not violate 3638. I do not want to split this because i already commited changelog entry with link to this topic.