Page 1 of 1

[posila] [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Sat Mar 09, 2019 8:04 pm
by elendiastarman
Examples:
Screen Shot 2019-03-09 at 2.39.54 PM.png
Screen Shot 2019-03-09 at 2.39.54 PM.png (306.38 KiB) Viewed 4746 times
Screen Shot 2019-03-09 at 2.59.16 PM.png
Screen Shot 2019-03-09 at 2.59.16 PM.png (614.58 KiB) Viewed 4746 times
Screen Shot 2019-03-09 at 3.10.46 PM.png
Screen Shot 2019-03-09 at 3.10.46 PM.png (32.88 KiB) Viewed 4744 times
Screen Shot 2019-03-09 at 3.11.04 PM.png
Screen Shot 2019-03-09 at 3.11.04 PM.png (41.43 KiB) Viewed 4744 times
Screen Shot 2019-03-09 at 3.11.24 PM.png
Screen Shot 2019-03-09 at 3.11.24 PM.png (30.31 KiB) Viewed 4744 times
Details:
* MacBook Pro (2014/2015?) on Mojave
* GUI scale was set to 75% automatically; I bumped it back up to 100%.
* Not all zoom levels show jagged edges.
* More zoom levels show jagged edges when more turrets are on screen.
* Does not happen with single turrets or a well-separated pair (ranges overlap but do not cover the other turret).
* The grid of filled-in "pixels" seems to be stationary.
* Can be smooth or rasterized at the same zoom level depending on where the map is panned.

Re: [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Mon Mar 11, 2019 12:55 pm
by posila
Thanks for the report.
Please post also Factorio log from

Code: Select all

~/Library/Application Support/factorio/factorio-current.log

Re: [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Mon Mar 11, 2019 1:31 pm
by BlueTemplar
Which is more accurate in practice - jagged or not jagged ?

EDIT : Remember M.A.X. ?
Image
IIRC you could only fire on an enemy if his tile was >50% in your range disk...
https://www.maxr.org/

Re: [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Mon Mar 11, 2019 4:36 pm
by elendiastarman
posila wrote: Mon Mar 11, 2019 12:55 pm Thanks for the report.
Please post also Factorio log from

Code: Select all

~/Library/Application Support/factorio/factorio-current.log
factorio-current.log
(8.04 KiB) Downloaded 194 times

Re: [posila] [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Fri Jun 14, 2019 2:13 pm
by posila
Thanks for the report.
It's a bug in macOS Intel shader compiler - it doesn't align structures in uniform buffer as specified.
We found a workaround and added it to 0.17.50

Re: [posila] [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Sat Jun 22, 2019 8:41 am
by DBotThePony
After this change on .50 limited arcs of turrets render jagged at some zoom levels on Radeon R9 270 (Windows 10)
factorio_15-41-10-4497dea.png
factorio_15-41-10-4497dea.png (28.16 KiB) Viewed 4344 times
factorio_15-41-03-3e7912c.png
factorio_15-41-03-3e7912c.png (31.71 KiB) Viewed 4344 times

Re: [posila] [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Sat Jun 22, 2019 7:10 pm
by posila
DBotThePony wrote: Sat Jun 22, 2019 8:41 am After this change on .50 limited arcs of turrets render jagged at some zoom levels on Radeon R9 270 (Windows 10)
Hello, please post your log.
Press Win + R, type in %APPDATA%\Factorio and click OK. File Explorer should open and you should see file called factorio-current.log.

Re: [posila] [0.17.9] Turret range overlay in map is jagged at some zoom levels

Posted: Sun Jun 23, 2019 7:11 am
by posila
DBotThePony wrote: Sat Jun 22, 2019 8:41 am After this change on .50 limited arcs of turrets render jagged at some zoom levels on Radeon R9 270 (Windows 10)
Thanks for the report.
Fixed for 0.17.51