Page 1 of 1
[1.1.32] Lights render resolution option does absolutely nothing
Posted: Sat Apr 24, 2021 4:47 pm
by Hornwitser
I was curious how this graphics option updated on the fly, and tried to make the rendering resolution of lights increase. But no matter how much I switched between 0.25 and 1 at night I couldn't see any difference at all, even after restarting the game.
So I started digging and found DrawEngine.cpp:611 and EngineFramebuffers.cpp:144 and now I'm convinced this option does absolutely nothing.
Re: [1.1.32] Lights render resolution option does absolutely nothing
Posted: Sat Apr 24, 2021 5:26 pm
by posila
You are correct. In 1.1 light rendering was changed to separate light maps affecting large areas (like lamps) and detail lights that are usually just tiny LEDs. Area lights are very GPU intensive when rendered in full resolution, while having no (or barely any) extra visual fidelity from being rendered in higher resolution, while detail lights suffer from flickering during movement when rendered in lower resolution, especially when zoomed out. So, point is ... the option is no longer required (and is not used), but there is currently nothing to put in its place, and just removing it from the GUI would break the nice alignment of the two halves of the GUI, so I have left it there
Re: [1.1.32] Lights render resolution option does absolutely nothing
Posted: Sat Apr 24, 2021 5:30 pm
by eradicator
posila wrote: Sat Apr 24, 2021 5:26 pm
removing it from the GUI would break the nice alignment of the two halves of the GUI, so I have left it there :)
ymmd :D
Re: [1.1.32] Lights render resolution option does absolutely nothing
Posted: Sun May 02, 2021 5:24 pm
by posila
Ok, I decided to not be lazy piece of ... human being today and removed the option for the next release.
Thanks for the report.