Page 1 of 1

Fluid Wagons When Train is on Curved Rail

Posted: Tue Nov 24, 2020 2:28 pm
by adam_bise
TL;DR
Allow fluid wagons to work when part of the train is on a curved rail by changing the pump arm graphic.

What ?
viewtopic.php?p=500666#p500666

The way it is now looks dang pretty, but pumps wont connect to fluid wagons when part of the train is on a curved rail due to a precise alignment requirement of the pump arm graphic.

As boskid says in the bug forum, the best solution would be to change the graphic of the pump arm, so that it has a higher alignment tolerance.
Why ?
In my opinion, having fluid wagons that actually function on slightly misaligned trains is more valuable than a highly precise pump arm graphic.

Re: Fluid Wagons When Train is on Curved Rail

Posted: Tue Nov 24, 2020 3:49 pm
by ptx0
adam_bise wrote: Tue Nov 24, 2020 2:28 pm In my opinion, having fluid wagons that actually function on slightly misaligned trains is more valuable than a highly precise pump arm graphic.
+1

would help with mods like TinyTrains.

Re: Fluid Wagons When Train is on Curved Rail

Posted: Wed Nov 25, 2020 1:01 am
by ssilk
Please avoid quoting a full post to add “1”. :)

Edit: thanks.

Re: Fluid Wagons When Train is on Curved Rail

Posted: Wed Nov 25, 2020 9:23 am
by Rseding91
Just FYI: the current pump is 11.4 megabytes across 222 sprite sheets. It's already insane with all of the directions and animations it has.

Re: Fluid Wagons When Train is on Curved Rail

Posted: Wed Nov 25, 2020 5:38 pm
by adam_bise
Rseding91 wrote: Wed Nov 25, 2020 9:23 am Just FYI: the current pump is 11.4 megabytes across 222 sprite sheets. It's already insane with all of the directions and animations it has.
Would it be possible to remove all of those variations and correct the connection issue by splitting the graphic into two pieces, and have the telescoping arm and hose part of the graphic stretch to the target on the fluid wagon?

Re: Fluid Wagons When Train is on Curved Rail

Posted: Wed Nov 25, 2020 6:08 pm
by ptx0
Rseding91 wrote: Wed Nov 25, 2020 9:23 am Just FYI: the current pump is 11.4 megabytes across 222 sprite sheets. It's already insane with all of the directions and animations it has.
just make it procedural like inserter arms / spidertron legs.

Re: Fluid Wagons When Train is on Curved Rail

Posted: Thu Nov 26, 2020 5:13 am
by ssilk
I think Factorio should just be not so picky about the right position of that arm. If it is in this rare case some pixels wrong who cares? (I mean: when someone builds such crazy stations :) she/he must live with a very small, nearly invisible graphical glitch)

Also the latest idea in linked post.

Re: Fluid Wagons When Train is on Curved Rail

Posted: Thu Nov 26, 2020 8:23 am
by Koub
ssilk wrote: Thu Nov 26, 2020 5:13 am If it is in this rare case some pixels wrong who cares? (I mean: when someone builds such crazy stations :)
People who file bug reports for 1 pixel misalignment issues :lol:

Re: Fluid Wagons When Train is on Curved Rail

Posted: Mon Nov 30, 2020 7:07 pm
by adam_bise

Re: Fluid Wagons When Train is on Curved Rail

Posted: Tue Dec 01, 2020 2:58 am
by foamy
adam_bise wrote: Tue Nov 24, 2020 2:28 pm In my opinion, having fluid wagons that actually function on slightly misaligned trains is more valuable than a highly precise pump arm graphic.
I absolutely concur. It drives me batty when it looks like a fluid wagon is exactly aligned, but, owing to pi, isn't, and so the pumps can't connect. A few degrees of swing would make life so much easier. Might also allow connecting pumps to fluid wagons that are themselves on curved rails, as you can with inserters and solid-item wagons.