Page 1 of 1

[1.0.0] Mod portal accepted mod that the game can not load

Posted: Fri Aug 21, 2020 1:15 pm
by Foltik
1. What did you do?
I tried to download the mod "Yuoki Industries" (https://mods.factorio.com/mod/Yuoki) version 1.0.01 from the mod portal while in-game.

2. What happened?
The download starts, and finishes. I switch back to the "Manage" tab, but the mod isn't there. The mod, "Yuoki_1.0.01.zip" is now present in the factorio mods folder. I click "Confirm", and the game restarts, but the mod is still not in the "Manage" list.

This happens every time I try it, even on different computers.

I think it may be related to the leading zero in the version, as the mod shows up in the portal and in dependencies of other mods as "1.0.1", even though the actual version is "1.0.01". In the logs, I see "Mod package read error" ... "error code -103".

3. What did you expect to happen instead?
I expected the mod to show up in the mod list. If something went wrong, I would expect some sort of visual feedback.

If the info.json has errors, I would expect that when uploading the mod to the portal it would be rejected.

Re: [1.0.0] Mod from portal not showing up in mod list after install

Posted: Fri Aug 21, 2020 1:32 pm
by Foltik
I looked in the mod's zip file and the info.json seems to be missing entirely.

Re: [1.0.0] Mod from portal not showing up in mod list after install

Posted: Fri Aug 21, 2020 1:35 pm
by Foltik
From Sindelin on the mod's discussion page:

It is wrong compression method in the .zip file. It seems the built-in unzip in Factorio cannot handle this method.

I have unpacked the file with latest WinRar and repacked into regular zip file. No changes into files. And it works.
Also this same problem has Yuoki Engines (yi_engines_1.0.44)

Re: [1.0.0] Mod from portal not showing up in mod list after install

Posted: Fri Aug 21, 2020 3:15 pm
by Loewchen
Based on viewtopic.php?p=425043#p425043, just ignoring mods the game can not load is intended.

Re: [1.0.0] Mod from portal not showing up in mod list after install

Posted: Fri Aug 21, 2020 4:23 pm
by Foltik
I can understand the game ignoring some random badly formatted mod, but shouldn't the mod have been verified to be correctly formatted when it was uploaded to the portal?

Re: [1.0.0] Mod from portal not showing up in mod list after install

Posted: Fri Aug 21, 2020 4:47 pm
by Loewchen
Ok, the mod portal seems to have had no problem accepting the file but neither the game nor windows 7 can open its contents.
Not sure what is actually wrong, it presents as uncompressed and 7zip has no issue with it.

Re: [1.0.0] Mod from portal not showing up in mod list after install

Posted: Fri Aug 21, 2020 4:56 pm
by eradicator
Loewchen wrote: Fri Aug 21, 2020 4:47 pm Not sure what is actually wrong, it presents as uncompressed and 7zip has no issue with it.
Not sure what factorio uses, but i've encountered several programs in the past that don't handle "not compressed" zip files. I usually use deflate even if i know that the content is not compressible (i.e. png files). Maybe the mod portal should do an automatic "can load" test.

@OP: Have you reported this to Yuoki?

Re: [1.0.0] Mod accepted mod that the game can not load

Posted: Fri Aug 21, 2020 5:03 pm
by Foltik
Yes, there's a thread about it on the mod: https://mods.factorio.com/mod/Yuoki/dis ... f19b0a98a3