Page 1 of 1

[0.11.16] Logistics doesn't check max space in container.

Posted: Mon Feb 23, 2015 6:15 pm
by ofca
Setting request chest to request 20k of an item results in drones doing their best to deliver impossible amounts of goods, which results in DDoS :)

Re: [0.11.16] Logistics doesn't check max space in container

Posted: Tue Feb 24, 2015 12:09 am
by bobingabout
Nothing wrong with 20k, it does take time, but sometimes you want to actually fill a box with 20k of something, or more. Now, if those items do exist when you start the request, it takes a long time, with a huge swarm of robots working on it, but imagine more of a situation where you want to fill a box with copper ore, and havn't started mining the copper yet, when the mines start, the drones will take the copper as it is mined. Of course a better solution to move that copper would be to use active provider chests, but still, its a use.

Re: [0.11.16] Logistics doesn't check max space in container

Posted: Tue Feb 24, 2015 12:34 pm
by ofca
What box has 20k of storage? Mine reach their top at 4.8k (if stored item stacks in 100 pieces) - besides, the bug isn't about 20k, but about drones trying to store more than will ever be possible for a box, which results in kilometer-long tails of drones flying back and forth ;)

Re: [0.11.16] Logistics doesn't check max space in container

Posted: Tue Feb 24, 2015 8:08 pm
by bobingabout
Mods. Some items in mods have really high stack counts, in some cases 20k isn't enough.

Also, when the box does get filled they stop trying to deliver items to it.

Re: [0.11.16] Logistics doesn't check max space in container

Posted: Wed Feb 25, 2015 3:19 am
by ofca
Again, you're missing the point. When box is full then they do try to stop delivering things, however once the box stops being full, logistics network ignores the max box size and happily tries to deliver 20k plates into 4.8k storage chest. This is obviously easily worked around by not setting absurd amounts, however I was treating intuitively the 20k value as "max".

Re: [0.11.16] Logistics doesn't check max space in container

Posted: Wed Feb 25, 2015 8:01 pm
by fregate84
agree. Logistics system should use, for blue box, the maximum(requested_quantity;size_box_available) for requested quantity and not just requested quantity.

Re: [0.11.16] Logistics doesn't check max space in container

Posted: Thu Feb 26, 2015 12:14 pm
by fregate84