times of day in script are named wrong.
Posted: Fri Jun 05, 2020 9:29 pm
Quoted here are the script names for times of day, with the parts in brackets added because it's the only way I can figure out what each does:
This image shows actual times of day:
Every time I read the internal names, it bugs me, because dawn and morning are synonymous (mean (almost) the same thing) likewise dusk and evening are also synonymous.
According to those definitions, you have Day, Night, Morning twilight and Evening twilight... though... see above for synonyms.
Phase naming:
What in game is named Morning should be named Dawn. (though Morning works if you're going with "Morning Twilight")
what in game is named Dawn should be named Day.
what in game is named Dusk... is correct! (Or "Evening" if you want to shorten "evening Twilight")
what in game is named Evening should be named Night.
Point in time naming:
What in game is named Morning should be named Dawn.
what in game is named Dawn should be named Sunrise.
what in game is named Dusk should be named Sunset.
what in game is named Evening should be named Dusk.
So, that's 2 different possible methods, with 2 different possible naming conventions for one of them... as a general rule, Morning/Evening should not be used at the same time as Dawn/Dusk, as they're synonymous with that phase of the day.
I mean, at this point in time, I accept that you can't really do anything to fix it, as it will break any mod that plays with these values, and even worse, they re-use names that do something different than they do now.
I'm mostly typing this to complain and get things off my chest, because every time I look at this page and see those definitions, it makes me angry, or at least confused.
Code: Select all
morning :: double [RW] The daytime when morning starts. (End of night, starting to get light)
dawn :: double [RW] The daytime when dawn starts. (Start of day, fully light)
dusk :: double [RW] The daytime when dusk starts. (End of day, starting to get dark)
evening :: double [RW] The daytime when evening starts. (Start of night, fully dark)
Every time I read the internal names, it bugs me, because dawn and morning are synonymous (mean (almost) the same thing) likewise dusk and evening are also synonymous.
According to those definitions, you have Day, Night, Morning twilight and Evening twilight... though... see above for synonyms.
Phase naming:
What in game is named Morning should be named Dawn. (though Morning works if you're going with "Morning Twilight")
what in game is named Dawn should be named Day.
what in game is named Dusk... is correct! (Or "Evening" if you want to shorten "evening Twilight")
what in game is named Evening should be named Night.
Point in time naming:
What in game is named Morning should be named Dawn.
what in game is named Dawn should be named Sunrise.
what in game is named Dusk should be named Sunset.
what in game is named Evening should be named Dusk.
So, that's 2 different possible methods, with 2 different possible naming conventions for one of them... as a general rule, Morning/Evening should not be used at the same time as Dawn/Dusk, as they're synonymous with that phase of the day.
I mean, at this point in time, I accept that you can't really do anything to fix it, as it will break any mod that plays with these values, and even worse, they re-use names that do something different than they do now.
I'm mostly typing this to complain and get things off my chest, because every time I look at this page and see those definitions, it makes me angry, or at least confused.
