Page 1 of 1

[0.11.13] invalid gui style still crashes

Posted: Tue Jan 27, 2015 6:45 pm
by prg
https://forums.factorio.com/forum/vie ... =11&t=8028 is not fixed

Code: Select all

game.player.gui.top.add{type="button", caption="crashme", style="invalid"}
segfault

Re: [0.11.13] invalid gui style still crashes

Posted: Tue Jan 27, 2015 7:38 pm
by Choumiko
i assume it is an invalid (as in not existing) style? Because today i assigned a (valiid/existing) style to a wrong type and got an error instead of crash.

Re: [0.11.13] invalid gui style still crashes

Posted: Tue Jan 27, 2015 7:46 pm
by prg
Right, the provided code causes the crash.

edit: ...so it's completely invalid style vs. wrong type of style for the gui element, different bug then.

Re: [0.11.13] invalid gui style still crashes

Posted: Wed Jan 28, 2015 9:55 am
by kovarex
Yes ... the check is there, but there is error in the check because I didn't test it.

So I fixed it and added automated test of it.