Page 1 of 1

[0.17.79] Illegal character notice when saving doesn't clear with the enter key

Posted: Tue Dec 31, 2019 4:44 am
by slortibort
1. What did you do?: I attempted to save a game with the name "Time to go!". This brought up a message reading "Notice - Character "!" can't be part of the file name." I then pressed enter to progress/clear the notice.

2. What happened?: Nothing. The notice didn't clear when pressing the enter key on my keyboard. I had to use the mouse to click on the "Confirm" button to clear it.

3. What did you expect to happen instead? It might be obvious to you, but do it anyway!: I'd expect the enter button to clear/progress/accept the message. It works in the rest of the menus as far as I can see. At this point, I'm pretty trained to press enter to clear or accept messages in menus like that and it was oddly jarring that it didn't work for just this one notice.

It's pretty minor all things considered. Perhaps I'm just a lazy sod and should take the 2 seconds to use the bloody mouse! :roll: That said, it certainly seems like an oversight in the menu UI.

Re: [0.17.79] Illegal character notice when saving doesn't clear with the enter key

Posted: Tue Dec 31, 2019 4:54 pm
by Squelch
Confirmed.

This does seem to be an odd one, and contributes to an inconsistent user experience

Re: [0.17.79] Illegal character notice when saving doesn't clear with the enter key

Posted: Thu Jan 02, 2020 11:26 am
by Klonan
Keyboard control isn't implemented in a lot of places, and lack of it isn't a bug

Some specific places have keyboard controls, such as saving or loading games. Another one is that ESC works on most dialog boxes to cancel.

Re: [0.17.79] Illegal character notice when saving doesn't clear with the enter key

Posted: Thu Jan 02, 2020 2:23 pm
by Squelch
Klonan wrote: Thu Jan 02, 2020 11:26 am Keyboard control isn't implemented in a lot of places, and lack of it isn't a bug

Some specific places have keyboard controls, such as saving or loading games. Another one is that ESC works on most dialog boxes to cancel.
Please excuse me @Klonan, but I must respectfully challenge you on your decision to mark this as "not a bug". By doing so, it signals to players that this and similar behaviours are intentional, and that they should not be reported. I do not believe that it is intentional (unless you say otherwise) but an oversight that will need polish at a later date along with the other areas you mention.

Keeping only to this report, that particular dialog is modal, ie It has sole focus until dismissed, and furthermore there are no other choices that the player can make that would require a pointer. Allowing a single input method is not only unconventional with software in general, but inconsistent with the majority of the Factorio user interface. Just because there are other instances, it should not excuse the inconsistency, and in fact, other instances should be encouraged to be reported too so they may be tracked for attention when the time comes for polish.

This may qualify as a very minor bug, but it is a bug that needs to be entered into your bug tracker in my humble opinion. If this example is already being tracked, then please accept my apologies. My concern is with the perception of defect reports (even minor ones) being dismissed as "not a bug" to the detriment of overall quality in the game.

[Edit for clarity]

Re: [0.17.79] Illegal character notice when saving doesn't clear with the enter key

Posted: Thu Jan 02, 2020 5:05 pm
by Klonan
Squelch wrote: Thu Jan 02, 2020 2:23 pm Please excuse me @Klonan, but I must respectfully challenge you on your decision to mark this as "not a bug". By doing so, it signals to players that this and similar behaviours are intentional, and that they should not be reported. I do not believe that it is intentional (unless you say otherwise) but an oversight that will need polish at a later date along with the other areas you mention.

It is a feature that doesn't exist for this GUI, logic that is not written yet, but it is not a bug, nothing is behaving outside of expectation. If we want to add Enter to confirm to the dialogs, that is an idea we will consider, however it is not a bug.

Re: [0.17.79] Illegal character notice when saving doesn't clear with the enter key

Posted: Fri Jan 03, 2020 1:52 am
by Squelch
Klonan wrote: Thu Jan 02, 2020 5:05 pm It is a feature that doesn't exist for this GUI, logic that is not written yet, but it is not a bug, nothing is behaving outside of expectation. If we want to add Enter to confirm to the dialogs, that is an idea we will consider, however it is not a bug.
Thank you for taking the time to expand on the reasoning. I do agree that if the code has not been written to handle other input methods, then technically it is not a bug. Please understand that from a user perspective, the expectation is that common interactions behave in a similar manner, and as @slortibort has observed, it can be jarring. We, as players, are not privy to the codebase, and therefore do not know what has, or has not been implemented in code, so therefore it might appear as a bug or unintended behaviour. I accept that it is indeed perhaps an incomplete feature, and I'll make a suggestion in the appropriate sub forum as you advise.