Page 1 of 1

[posila] [0.17.63] Controls settings confuses 'ö' with '0'

Posted: Wed Aug 07, 2019 3:03 pm
by Gergely
When I'm setting a keybind in the controls settings, the game displays the character 0 when it's supposed to display the character ö. During game play however, the right action is triggered for the right keybind, so this is just a visual bug. I also noted that for accented letters, their lowercase is used while all other letters use their uppercase. On my keyboard, every letter is in uppercase. Here's my layout for reference:
Image

What's on the keyboard -> What the game displays in the menu

Code: Select all

A -> A
B -> B
C -> C
Í -> í
Ö -> 0 (!)
Ü -> ü
Ó -> ó
Ő -> ő
Ú -> ú
É -> é
Á -> á
Ű -> ű

Re: [0.17.63] Controls settings confuses 'ö' with '0'

Posted: Wed Aug 07, 2019 3:16 pm
by Bilka
Cannot reproduce. What is your system language and system keyboard set to? Is the keyboard layout that is set in your system the same as the one you physically use?
Image

Re: [0.17.63] Controls settings confuses 'ö' with '0'

Posted: Wed Aug 07, 2019 6:20 pm
by posila
Ok, I figured it out. It is SDL2 forcing top row of keys to number keycodes. The comment says it is so that French AZERTY shows numbers instead of accent key. So I added check for Hungarian layout.

Fixed for 0.17.64

In case other developers google this problem:
https://github.com/SDL-mirror/SDL/blob/ ... ard.c#L129
https://github.com/SDL-mirror/SDL/commi ... 3b22bf2ec8

Re: [0.17.63] Controls settings confuses 'ö' with '0'

Posted: Thu Aug 08, 2019 5:25 am
by Gergely
posila wrote: Wed Aug 07, 2019 6:20 pmIn case other developers google this problem:
Yeah I was about to google what SDL is before I read the links. This is the good old fashioned bug that appears right after fixing another.

Is the lowercase part intended (Not a bug) or is simply not worth the time it would take to fix? (Won't fix) I assume it is the latter because no one commented on it yet.

Re: [0.17.63] Controls settings confuses 'ö' with '0'

Posted: Thu Aug 08, 2019 5:31 am
by posila
Gergely wrote: Thu Aug 08, 2019 5:25 amIs the lowercase part intended (Not a bug) or is simply not worth the time it would take to fix? (Won't fix) I assume it is the latter because no one commented on it yet.
It's Won't fix.