Rename the day/night phase names in the API
Posted: Mon Oct 22, 2018 6:30 am
Hello,
I find the current names of the day and night phases in the API *really* confusing since they're mostly synonyms and since what they represent in the code doesn't line up with the definitions of the words.
Currently the phases are: dusk, dawn, evening, morning
And they represent the parts of the day which respectively: darken, are brightest, are darkest, brighten.
Dawn as a word means "before sunrise" and can easily be confused with morning which is "the period of time between midnight and noon". These two are the most difficult to reconcile since in reality dawn ends before morning ends, but in the API morning ends and dawn begins.
Evening as a word typically means after the afternoon and before night and can easily be confused with dusk.
In a perfect world I would propose naming them: morning, day, evening, night or alternatively dawn, day, dusk, night.
Realistically, you likely don't want to rename one phase of the day with a word that used to be associated with a different phase, so in that case just renaming dawn to day and evening to night would at least eliminate the opportunity for confusion.
I find the current names of the day and night phases in the API *really* confusing since they're mostly synonyms and since what they represent in the code doesn't line up with the definitions of the words.
Currently the phases are: dusk, dawn, evening, morning
And they represent the parts of the day which respectively: darken, are brightest, are darkest, brighten.
Dawn as a word means "before sunrise" and can easily be confused with morning which is "the period of time between midnight and noon". These two are the most difficult to reconcile since in reality dawn ends before morning ends, but in the API morning ends and dawn begins.
Evening as a word typically means after the afternoon and before night and can easily be confused with dusk.
In a perfect world I would propose naming them: morning, day, evening, night or alternatively dawn, day, dusk, night.
Realistically, you likely don't want to rename one phase of the day with a word that used to be associated with a different phase, so in that case just renaming dawn to day and evening to night would at least eliminate the opportunity for confusion.