[0.16.50] Game hanging when calculating Total row in recipe

We are aware of them, but they have low priority. We have more important things to do. They go here in order not to take space in the main bug thread list.

[0.16.50] Game hanging when calculating Total row in recipe

Postby _npo6ka_ » Wed Jul 04, 2018 6:49 pm

I play the factorio modpak seablock pack 0.2.11. I'm also developing a mod. When developing, I ran into the following problem: when I use the "choose-elem-button" for recipes (elem_type = "recipe"), the game freezes for 1-2 seconds when you hover over the "choose-elem-button" when the recipe is complex. For example a rocket silo recipe.

IMG
Image

When I point the cursor at it the game freezes for 2 seconds. Maybe it's worth it to revise the display option tooltip for choose-elem-button.
Last edited by _npo6ka_ on Wed Jul 04, 2018 7:32 pm, edited 1 time in total.
_npo6ka_
Long Handed Inserter
Long Handed Inserter
 
Posts: 84
Joined: Mon Sep 26, 2016 10:29 pm

Re: Game hanging when calculating Total row in recipe tooltip

Postby _npo6ka_ » Wed Jul 04, 2018 7:01 pm

To reproduce the error, you can use the old version of FNEI installed in the seablock pack.
Steps:
1) Open FNEI (ctrl + E)
2) Choose rocket silo
img
Image

3) Click the "craft" button
img
Image

4) Hover the "elem-choose-button" with the rocket silo recipe in the upper left corner
img
Image
_npo6ka_
Long Handed Inserter
Long Handed Inserter
 
Posts: 84
Joined: Mon Sep 26, 2016 10:29 pm

Re: [0.16.50] Game hanging when calculating Total row in recipe

Postby Rseding91 » Mon Aug 13, 2018 1:33 am

Thanks for the report however that's working correctly. Simply you've got a set of mods that produces a "total" of crazy amounts of items/fluids and it takes quite some time to do the calculation of "how much of what does it take".

You've gone beyond what can the current system can reasonably handle and will have to cut back on some of the recipes if you want it to perform better.
If you want to get ahold of me I'm almost always on IRC and Discord.
Rseding91
Factorio Staff
Factorio Staff
 
Posts: 7708
Joined: Wed Jun 11, 2014 5:23 am

Re: [0.16.50] Game hanging when calculating Total row in recipe

Postby eradicator » Mon Aug 13, 2018 4:26 am

Rseding91 wrote:Thanks for the report however that's working correctly. Simply you've got a set of mods that produces a "total" of crazy amounts of items/fluids and it takes quite some time to do the calculation of "how much of what does it take".

Can't you memoize the function that calculates the "total raw" numbers? You'd have to (at least partially) throw away the cached data when new recipies are unlocked...meh. But given how often these numbers are shown during gameplay it seems like they shouldn't be recalculated every single time the mouse is moved.
User avatar
eradicator
Smart Inserter
Smart Inserter
 
Posts: 1919
Joined: Tue Jul 12, 2016 9:03 am
Location: Mod support languages: JA/DE/EN


Return to Minor issues

Who is online

Users browsing this forum: No registered users and 1 guest