Page 1 of 2

Standing in a shadow looks weird

Posted: Sun Apr 08, 2018 5:51 pm
by leadfeather89
Title.

I don't know how to post pictures in the forum, but here is an imgur link. https://imgur.com/wVxdrYR

Image[/quote]

Re: Standing in a shadow looks weird

Posted: Sun Apr 08, 2018 9:51 pm
by Gergely
Quoted from here: p233989. Altered to be "on topic".
Image corrected

Re: Standing in a shadow looks weird

Posted: Sun Apr 08, 2018 10:04 pm
by DaveMcW
It's even better at night.
lamp.jpg
lamp.jpg (257.54 KiB) Viewed 6273 times

Re: Standing in a shadow looks weird

Posted: Sun Apr 08, 2018 10:23 pm
by Gergely
DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 12:09 am
by leadfeather89
Now I can't unsee it.

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 12:49 pm
by gsezz
Fading shadows in and out at sunrise and sunset might have a huge impact on performance. And making them suddenly disappear would look be even worse.

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 1:48 pm
by mrvn
Really? Isn't that just a black area with alpha value? Changing the alpha value for all shadows sounds relatively easy to do once a second.

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 2:40 pm
by Deadlock989
Gergely wrote:
DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:
Not going to happen. Some entities (usually the larger ones) have a separate shadow layer. Some don't, the shadow is part of the sprite. Then there are mods, which might do either or both or neither.

It's not a 3D game, guys.

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 5:07 pm
by Jap2.0
DaveMcW wrote:It's even better at night.
lamp.jpg
WHAT HAVE YOU DONE!?

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 5:53 pm
by eradicator
The "lamp" is actually just a targeting marker for an orbital long-range spotlight, it doesn't produce the light itself :P.

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 10:15 pm
by leadfeather89
Deadlock989 wrote:
Gergely wrote:
DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:
It's not a 3D game, guys.
Yeah, but they definitely are kinda pretending it is with the addition of cliffs.

Re: Standing in a shadow looks weird

Posted: Mon Apr 09, 2018 11:08 pm
by Deadlock989
leadfeather89 wrote:Yeah, but they definitely are kinda pretending it is with the addition of cliffs.
Yeah, well, best game in the world, they're allowed a couple of duff moves.

Re: Standing in a shadow looks weird

Posted: Tue Apr 10, 2018 8:52 am
by mrvn
Deadlock989 wrote:
Gergely wrote:
DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:
Not going to happen. Some entities (usually the larger ones) have a separate shadow layer. Some don't, the shadow is part of the sprite. Then there are mods, which might do either or both or neither.

It's not a 3D game, guys.
So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.

Re: Standing in a shadow looks weird

Posted: Tue Apr 10, 2018 8:54 am
by Deadlock989
You make it sound so trivial. Knock yourself out.

Re: Standing in a shadow looks weird

Posted: Tue Apr 10, 2018 11:02 am
by eradicator
mrvn wrote:So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.
Congratulations. You just doubled the VRAM requirement for factorio.

Re: Standing in a shadow looks weird

Posted: Tue Apr 10, 2018 11:41 am
by mrvn
eradicator wrote:
mrvn wrote:So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.
Congratulations. You just doubled the VRAM requirement for factorio.
If that is your problem then combine the entity layer with the shadow layer into a single layer at runtime. Just refresh that cached image every so often as light levels change. You don't have to keep both images in VRAM, you only need to know which part of the image needs to be adjusted for light levels. More work to code but surely not impossible.

Re: Standing in a shadow looks weird

Posted: Tue Apr 10, 2018 11:52 am
by Deadlock989
To me all that sounds like a buttload of work for something incredibly trivial that is not even guaranteed to be noticed when you zoom in to maximum during the less than 50% of the time that it's night. If just one minute spent on carping like this takes away time and resources from all the other cool new stuff in the pipeline, that is an epic fail. Please just stop it.

Re: Standing in a shadow looks weird

Posted: Tue Apr 10, 2018 4:04 pm
by bobucles
There's a reason overhead tile based games don't do shadows.

Re: Standing in a shadow looks weird

Posted: Tue Apr 10, 2018 5:17 pm
by dood
mrvn wrote:
eradicator wrote:
mrvn wrote:So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.
Congratulations. You just doubled the VRAM requirement for factorio.
If that is your problem then combine the entity layer with the shadow layer into a single layer at runtime. Just refresh that cached image every so often as light levels change. You don't have to keep both images in VRAM, you only need to know which part of the image needs to be adjusted for light levels. More work to code but surely not impossible.
And now you have the entity parts, shadow parts and a combined surface.
3 times the VRAM.

Re: Standing in a shadow looks weird

Posted: Wed Apr 11, 2018 9:53 am
by Sir3n
DaveMcW wrote:It's even better at night.
lamp.jpg
I always felt there was something wrong with night time in factorio. Now that you point it out, it's actually obvious why.

Honestly, i think removing shadows altogether or making it an option to do so probably won't lose much out of the game. I play league on no shadows and i don't have an issue with it.

At the very least, having no shadows would be much better than shadows on a lit lamp.