Page 1 of 1
[0.15.33, minor] changelog after changing mods
Posted: Wed Aug 30, 2017 10:43 am
by gheift
Hi,
the changelog, which shows up after the updater is also displayed, if the mod configuration is changed in game. I do expect the changelog not to show up after I change my mod configuration.
How to reproduce:
- use an old version of factorio
- let the game update itself (either via auto update or About → Check update)
- factorio restarts itself after the update
- the changelog is chown
- modify mod configuration (enable/disable/install/deinstall a mod)
- factorio restarts itself after the config change
- the changelog is shown again, but I do not expect it here
Kind regards,
Gerhard
Re: [0.15.33, minor] changelog after changing mods
Posted: Thu Aug 31, 2017 11:46 am
by kovarex
I tried to reproduce it (on windows), and it didn't do that.
It is controlled by command line parameter (whether the log should be shown or not), and I checked that there is code that explicitelly removes this parameter when restarting, so I don't know how could it happen.
What is the system you tried it on, Could you provide the log after it happens? (Both factorio-current and previous).
Re: [0.15.33, minor] changelog after changing mods
Posted: Thu Aug 31, 2017 12:16 pm
by Rseding91
kovarex wrote:I tried to reproduce it (on windows), and it didn't do that.
It is controlled by command line parameter (whether the log should be shown or not), and I checked that there is code that explicitelly removes this parameter when restarting, so I don't know how could it happen.
What is the system you tried it on, Could you provide the log after it happens? (Both factorio-current and previous).
I think that code is new to 0.16 as a fix for something else. So, it's probably fixed for 0.16.
Re: [0.15.33, minor] changelog after changing mods
Posted: Thu Aug 31, 2017 4:03 pm
by kovarex
I tested it in 0.15 and couldn't reproduce it as well, but whatever.
Re: [0.15.33, minor] changelog after changing mods
Posted: Fri Sep 01, 2017 11:54 pm
by gheift
Sorry for the late replay, I am running on Debian. Here are the requested logs:
So basically the --autoupdate-finished argument is not removed for the restart caused by installing a mod. Maybe its already fixed due to this bug report:
viewtopic.php?f=213&t=52217
Kind regards,
Gerhard
Re: [0.15.33, minor] changelog after changing mods
Posted: Sat Sep 02, 2017 7:36 am
by posila
gheift wrote:So basically the --autoupdate-finished argument is not removed for the restart caused by installing a mod. Maybe its already fixed due to this bug report:
viewtopic.php?f=213&t=52217
Yes, fix for
52217 also fixes this one. The bug is isolated to Linux and macOS versions; it is at least worth mentioning your OS, but it is always best to include the log when reporting a bug
Thanks for the report.