Page 1 of 1

[0.15.33] Opening autosave error: No error.

Posted: Tue Aug 22, 2017 1:45 am
by TheXavier
Release: Steam
Version: 0.15.33 (build 30852, win64, steam)
OS: Windows 7 64-bit
Processor: AMD FX-8120 Eight-core
Graphics card: 2x Zotac GTX 970 4GB, only one in operation for Factorio. SLI was not enabled, SLI bridge was not installed.
"C:" drive: solid state, all save data is on "C"
"K:" drive: Factorio (and all steams games) itself was installed to 2x striped spinning disk.
No mods are installed. Game is "vanilla"

Context:
Windows logs indicated a temperature warning occurred. Nexlix was streaming on a second monitor. The entire computer froze and locked up the screen at the moment an autosave was starting, with no progress indicated on the progress bar. The computer was unresponsive, and could not generate a screenshot. No error from Factorio was expected.

Steps to present error to user:
1. Launch Factorio via Steam.
2. Click "Play"
3: Click "Load Game"
4. Immediately presented with error:
Notice

Opening zip C:/Users/.../Factorio/saves/_autosave3.tmp.zip failed: No error.

[OK]
In the background, where a screenshot of the save is usually presented, is the following text:
Invalid or corrupt file
[Delete Save]
The file exists on disk, as well as with the 3 rotating autosaves. _autosave1.zip is 39,968kb. _autosave2.zip is 40,131 kb. _autosave3.zip is 40,222kb. _autosave3.tmp.zip is 2,850kb. Windows Zip utility and 7zip are both able to browse the valid .zip files. Neither tool can browse _autosave3.tmp.zip.

It is a short jump to conclude that due to the unexpected Windows shutdown, the .zip file was incomplete. Making use of the tmp file preserved the existing files on disk and did not cause a loss of data.

Workarounds:
Other autosaves work as expected. Existing autosave3 is the oldest of the 3, which is expected if a new one was being created.
Computer ventilation was cleaned and restarted.

Expected behavior:
While the save and restoration problems are not Factorio's fault or scope to repair, the popup error is uninformative. While it provides the explicit filepath to file on disk to make diagnostics, the error "No error" is not accurate in this context, as the zip file is corrupted. The underlying error "Invalid or corrupt file." is more accurate.

Further, the "Ok" and "Delete Save" buttons should not stack on top of each other. Corrupted saves are symptomatic of other problems, and if such an problem is also causing responsiveness issues, then it may be possible to accidentally double click.

Re: [0.15.33] Opening autosave error: No error.

Posted: Tue Aug 22, 2017 5:15 am
by Rseding91
Thanks for the report. I've fixed the error so it shows the proper string (I/O error) instead of "no error".

As for the buttons overlapping: the pop-up message centers on the GUI - the placement just happens to land where it does. I don't consider that a bug or anything we're looking to change.

Re: [0.15.33] Opening autosave error: No error.

Posted: Wed Aug 23, 2017 2:21 am
by TheXavier
Neat, thanks.

As a further enhancement, perhaps the .tmp.zip files should not be listed at all, since they are demonstrably incomplete saves.