Page 1 of 1

[0.13.17] Creating an invalid entity on_player_left_game

Posted: Fri Aug 19, 2016 1:46 am
by credomane
Creating an invalid entity on_player_left_game event hardlocks factorio.
Relevant portion of log
I had a typo in a mod I was playing around with. Attempts to play an audible message when a player quits the game (or dies). If the (incorrect) AlliedReinforcementsHaveFallen entity is created when a play died then the normal script error appears and you are sent back to the main menu. The correct entity name is AlliedForcesHaveFallen which behaves correctly. All remaining connected players will hear either allied forces have fallen or enemy forces have fallen depending on depending on their allegiances to the disconnecting player.

But if this error occurs when a player quits the game then *all* players will find their factorio client frozen immediately and must use the taskmgr to forcefully kill factorio. Including the player that quit the game.

[edit]
Forgot to attach the mod in question.

Re: [0.13.17] Creating an invalid entity on_player_left_game

Posted: Tue Aug 23, 2016 12:54 pm
by Klonan
Thanks for the report,

Lua mistakes aside, the game probably shouldn't hard crash from a script error

Re: [0.13.17] Creating an invalid entity on_player_left_game

Posted: Wed Aug 24, 2016 7:39 pm
by Rseding91
Fixed for 0.14.

Re: [0.13.17] Creating an invalid entity on_player_left_game

Posted: Wed Aug 24, 2016 8:03 pm
by Supercheese
That mod sure sounds a lot like Red Alerts. ;)

Re: [0.13.17] Creating an invalid entity on_player_left_game

Posted: Fri Aug 26, 2016 2:03 pm
by credomane
Supercheese wrote:That mod sure sounds a lot like Red Alerts. ;)
It is. Playing with a bunch of stuff in it. :)