Page 1 of 1
Achievement rounding issue
Posted: Fri Jul 01, 2016 10:56 am
by PiggyWhiskey
I recently hit 10k Circuits for the achievement, and noticed the rounding issue.
It should round down to give a more accurate impression of progress.
![Image](http://puu.sh/pMuMj/ad23cb030d.jpg)
Re: Achievement rounding issue
Posted: Fri Jul 01, 2016 12:01 pm
by Klonan
PiggyWhiskey wrote:I recently hit 10k Circuits for the achievement, and noticed the rounding issue.
It should round down to give a more accurate impression of progress.
![Image](http://puu.sh/pMuMj/ad23cb030d.jpg)
hmm, seems fine to me
Re: Achievement rounding issue
Posted: Fri Jul 01, 2016 12:05 pm
by PiggyWhiskey
That was about 30-60 seconds before the achievement triggered. No green background.
Re: Achievement rounding issue
Posted: Fri Jul 01, 2016 12:07 pm
by Klonan
PiggyWhiskey wrote:That was about 30-60 seconds before the achievement triggered. No green background.
Hmm okay
Thanks for the report
Re: Achievement rounding issue
Posted: Fri Jul 01, 2016 12:55 pm
by kovarex
I don't see anything in the image, and I don't know what is the issue.
Re: Achievement rounding issue
Posted: Fri Jul 01, 2016 12:57 pm
by Zeblote
kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
It's saying 10k/10k but the achievement didn't trigger yet. You're probably rounding these numbers up instead of down?
Re: Achievement rounding issue
Posted: Fri Jul 01, 2016 12:58 pm
by hoho
kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
The problem is that goal is to reach 10k and the display shows there to be 10.0k while in reality it's probably around 9.99k rounded up.
Re: Achievement rounding issue
Posted: Fri Jul 01, 2016 1:01 pm
by Klonan
kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
Mirror:
![Image](https://forums.factorio.com/images/ext/7ad64115a8c8f0ce06d877d761d5c6cf.png)
Re: Achievement rounding issue
Posted: Thu Jul 07, 2016 10:33 am
by kovarex
I don't consider it a bug, it is a way rounding works.
Re: Achievement rounding issue
Posted: Thu Jul 07, 2016 11:03 am
by HanziQ
How is this not a bug? If the value is 9999 for example, it should be displayed as 9.9k, not 10.0k. It maybe is the way rounding works, but it's the wrong rounding.
Re: Achievement rounding issue
Posted: Thu Jul 07, 2016 12:07 pm
by solntcev
Same issue with fluids display: often you can see (2.0 of 2) or (3.0 of 3) resources highlighted as red.
Maybe you need to make custom rounding function for displayed values? because rounding up make no sense in context of available resources.
Re: Achievement rounding issue
Posted: Thu Jul 07, 2016 3:42 pm
by hoho
kovarex wrote:I don't consider it a bug, it is a way rounding works.
That's the thing - rounding doesn't give the result a non-programmer would expect. It should be rounded *down*, not to closest full number.
Alternatively, why not just have higher precision numbers there? Just 3 significant positions doesn't make that much sense when you could fit pretty much anything there without too much trouble.