Page 1 of 1
Pipeline length should not be calculated between linked fluid boxes
Posted: Fri Jan 24, 2025 3:14 am
by sdgmlj
And this calculation is also unreasonable, only calculating coordinates
I establish links between different planets, as long as the coordinates are not significantly different, it can be used normally.
On the contrary, even on the same planet, if the coordinates differ too much, it cannot be used. Is this reasonable
So, my suggestion is that if it's a link, then it's cheating.
Since that's the case, there's no need to calculate the pipeline length between the two linked fluid boxes. I'm not sure if I've expressed myself clearly
Re: Pipeline length should not be calculated between linked fluid boxes
Posted: Fri Jan 24, 2025 3:39 am
by robot256
I agree, the way it compares coordinates on different surfaces makes it sound like an unintended consequence, and actually more of a bug than a feature. Linked pipe connections are only ever created by mods, so it should be the mods responsibility to ensure gameplay balance (if desired).
Re: Pipeline length should not be calculated between linked fluid boxes
Posted: Fri Jan 24, 2025 7:54 am
by Stringweasel
+1
99.9% of use cases for linked-fluidboxes the extent should not be extended.
Re: Pipeline length should not be calculated between linked fluid boxes
Posted: Sat Jan 25, 2025 9:58 am
by sdgmlj
Dear bosses, shouldn't this issue be addressed? I wrote a mod for two days and two nights, and now it's stuck here. My temporary solution is to increase the pipeline length limit, but I don't want to do it because it will change the game rules.
My suggestion is to add a fourth parameter to 'add_danked_connection'. When parameter 4 is set to true, the length of the connected fluid box will not be calculated. When parameter 4 is set to false or not, the original scheme will be maintained, which will not affect the original users. Do you think this scheme is feasible?
Re: Pipeline length should not be calculated between linked fluid boxes
Posted: Sat Jan 25, 2025 10:00 am
by sdgmlj
@ssilk
Re: Pipeline length should not be calculated between linked fluid boxes
Posted: Sat Jan 25, 2025 10:35 am
by boskid
This is quite unfortunate situation. Linked fluid box connections were added way before the idea of fluid segments was implemented, and when fluid segments were implemented they were known to cause problems with linked connections and for the sake of implementation (fluid segments were implemented relatively close to the SA release) it was made in a way that does not account for linked connections at all. Unless raiguard wants to get even more knee deep into fluids this is unlikely to be changed and the only proposed workaround right now is to use
UtilityConstants::default_pipeline_extent and
FluidBox::max_pipeline_extent with some ridiculus value of 4 000 000 so it is guaranteed to not be overextended. I will leave this in ideas for raiguard to give some feedback if he wants to.
Re: Pipeline length should not be calculated between linked fluid boxes
Posted: Sat Jan 25, 2025 11:10 am
by sdgmlj
boskid wrote: Sat Jan 25, 2025 10:35 am
This is quite unfortunate situation. Linked fluid box connections were added way before the idea of fluid segments was implemented, and when fluid segments were implemented they were known to cause problems with linked connections and for the sake of implementation (fluid segments were implemented relatively close to the SA release) it was made in a way that does not account for linked connections at all. Unless raiguard wants to get even more knee deep into fluids this is unlikely to be changed and the only proposed workaround right now is to use
UtilityConstants::default_pipeline_extent and
FluidBox::max_pipeline_extent with some ridiculus value of 4 000 000 so it is guaranteed to not be overextended. I will leave this in ideas for raiguard to give some feedback if he wants to.
Thank you, the method you mentioned is the one I am currently using, but I still feel that it is not very good. I don't know who you mean by 'raidguard', is it your boss? I hope he can see and take this issue seriously.
Re: Pipeline length should not be calculated between linked fluid boxes
Posted: Sat Jan 25, 2025 12:07 pm
by Nosferatu