Page 1 of 1

[2.0.14] Fluid in input buffer is destroyed when machine is deconstructed

Posted: Sat Nov 02, 2024 10:02 am
by LCStark
When a pipe is connected to a machine with fluid input, deconstructing that machine forces the fluid from machine's input back in the pipes:
11-02-2024, 10-59-28.png
11-02-2024, 10-59-28.png (251.3 KiB) Viewed 344 times
11-02-2024, 10-59-33.png
11-02-2024, 10-59-33.png (182.54 KiB) Viewed 344 times
In 1.1, you could extract the input fluid with a pump, but that doesn't work anymore:
11-02-2024, 11-00-39.png
11-02-2024, 11-00-39.png (310.17 KiB) Viewed 344 times
11-02-2024, 11-00-49.png
11-02-2024, 11-00-49.png (560.64 KiB) Viewed 344 times


Furthermore, when you deconstruct that machine with pump at its input, the fluid isn't pushed into the pump and just gets destroyed:
11-02-2024, 11-01-42.png
11-02-2024, 11-01-42.png (505.93 KiB) Viewed 344 times
The expected behaviour would be to let the pump extract input fluid when connected to it, but if that's how the new fluid system is supposed to work then I'd expect the fluid to be pushed into the pump when the machine is deconstructed.

Re: [2.0.14] Fluid in input buffer is destroyed when machine is deconstructed

Posted: Sat Nov 02, 2024 10:33 am
by boskid
Thanks for the report however there is nothing broken here.

Pump in 1.1 being able to pull fluid out of machine through input connection was a not intended consequence of pump pulling fluid while ignoring pipe connection direction. In 2.0 two pipes will not connect together if they are both input connections or both output connections as those cases are not useful.

When entity is marked to be deconstructed then it must disconnect all its fluid boxed because there may be ghost entities built on top that will be connecting visually to existing pipes and so when entity is deconstructed by a construction bot, the fluid cannot be pushed anywhere since machine is not connected at that point in time.

I am not considering anything here to be wrong, there are sone decisions to avoid fluids contamination when super force building blueprints over existing entities and most of the design decisions here are to make those cases work. Also we consider fluids cheap so losing a finite amount of them is ususlly not interesing for us too much.

Re: [2.0.14] Fluid in input buffer is destroyed when machine is deconstructed

Posted: Sat Nov 02, 2024 10:44 am
by LCStark
That is good to know, thanks! I did expect that to happen when deconstructing with bots, but the same thing happening when deconstructing manually caught me off-guard.