Page 1 of 1

[1.1.76] Checking for mod updates makes multiple redundant portal requests

Posted: Sat Feb 04, 2023 6:59 am
by raiguard
When the game checks for mod updates, it downloads the full mod list multiple times. The number of times it downloads it is proportional to the number of mods - with 5000 mods, it made 100 requests. You can see the URL that it is fetching in the log file:

Code: Select all

  85.659 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods?page_size=max&full=True&version=1.1.76&lang=en
  87.316 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods?page_size=max&full=True&version=1.1.76&lang=en
As you can see, it is not paginating, but is downloading the entire thing every time. That is a ton of redundant data!

Re: [1.1.76] Checking for mod updates makes multiple redundant portal requests

Posted: Sat Feb 04, 2023 8:52 am
by vinzenz
It's not logging the namelist parameter because it's in the http body. It makes 100 requests for 50 mods each.