Factorio Forums

Zeblote wrote:Anyways, this topic was about accessing the localized text in mods.

Where exactly is the problem with determinism, assuming we have the following:

- player variable that has the locale he is using
- method to get localized text given a specific string and locale
- event that runs when a player changes locale

aubergine18 wrote:Another example of a mod stymied by not being able to get actual translations for text - the search feature in "What does it do?" mod can only search on locale keys, not the translated names of items etc. viewtopic.php?p=210544#p210544

Coppermine wrote:If we can't request a particular string in a particular locale because not all players need to have the same locales installed then perhaps we can have a function to get the English localised name? That would still be better than what we have now. There are quite a lot of items where the internal name is quite different from the English localised name (e.g. mods often add prefixes for namespacing, which ruins sort order).

Coppermine wrote: Mon Jan 27, 2020 10:25 am In case anyone missed it, this is now possible (and has been for a while now) thanks to this addition to the API.

I just finished implementing localized string filtering for What is it Really Used For?, and it seems to work great. Thanks, devs!

eradicator wrote: Mon Jan 27, 2020 10:55 am Care to share a few details about the implementation? In particular how many requests do you dispatch at once? Or how long does it take to finish translation of a heavily modded game on a not-so-great connection etc?

Coppermine wrote: Mon Jan 27, 2020 11:36 am

eradicator wrote: Mon Jan 27, 2020 10:55 am Care to share a few details about the implementation? In particular how many requests do you dispatch at once? Or how long does it take to finish translation of a heavily modded game on a not-so-great connection etc?

You can of course look at the code. I just set up a memoised function that requests a translation if it's not already locally cached. It requests all the translations the first time you try to filter the list, so I suspect there might be a noticeable hiccup the first time each player uses the filter, but hopefully it should be fast after that.

I haven't tested on a multiplayer game.

eradicator wrote: Mon Jan 27, 2020 12:43 pm In that case i can tell you that it won't work in multiplayer. I tested the "request everything at once" approach myself before and it basically becomes impossible for anyone to join multiplayer servers even though it works fine in singleplayer.

Coppermine wrote: Mon Jan 27, 2020 11:37 pm

eradicator wrote: Mon Jan 27, 2020 12:43 pm In that case i can tell you that it won't work in multiplayer. I tested the "request everything at once" approach myself before and it basically becomes impossible for anyone to join multiplayer servers even though it works fine in singleplayer.

Thanks for the warning. Can you point me to any established best practices that have been found effective?

Coppermine wrote: Mon Mar 09, 2020 12:11 pm Ideally someone should probably roll all this into some standard library code (if they haven't already).

local function do_translations(player)
  local translation_data = {
    {internal="iron-ore", localised={"item-name.iron-ore"}},
    {internal="copper-ore", localised={"item-name.copper-ore"}},
    -- etc...
  }

  translation.start(player, 'ores', translation_data)
end

-- later on, somewhere
script.on_event(translation.finish_event, function(e)
  global.players[e.player_index].dictionary = {
    lookup = e.lookup,
    sorted_translations = e.sorted_translations,
    translations = e.translations
  }
end

lookup = {
  ["Iron ore"] = {"iron-ore"},
  ["Copper ore"] = {"copper-ore"}
}
sorted_translations = {
  "Copper ore",
  "Iron ore",
}
translations = {
  ["iron-ore"] = "Iron ore",
  ["copper-ore"] = "Copper ore"
}

eradicator wrote: Sun Apr 12, 2020 1:20 am After just looking at your examples... can your library handle these cases?

a) *different* translations for {'item-name.copper-ore'} and {'entity-name.copper-ore'} (recipe-name, etcpp).

b) Compound localised strings like {'__1__ blabla', {'item-name.copper-ore'}} (i.e. fluid barrels)

Also would you mind sharing how did you arrived at the solution of limiting per tick instead of per batch? (i.e. independant of network latency)

(Also thanks for sharing really! 50~100 batch size is at least a good starting point.)

Raiguard wrote: Sun Apr 12, 2020 3:55 am c) I'm not sure what you mean? The library has an array of localised strings that it needs to translate for every player. On every tick, it runs through the next n amount of translations, then saves the position where it ended. Then on the next tick it picks back up and does the next batch. Network latency has never been an issue, it just works.