Page 2 of 11

Re: [MOD 0.12.X] Big Bags 1.0.6

Posted: Thu Apr 28, 2016 8:10 pm
by binbinhfr
orzelek wrote:Thanks :)
It will be really helpful - might even tempt to play some death world due to increased ammo mags :D
Oh yes, biters are really fun toplay with, especially with my Super Tank. Give it a try ! :D

Re: [MOD 0.12.X] Big Bags 1.0.6

Posted: Fri Apr 29, 2016 6:10 pm
by orzelek
One more small improvement to consider:
Use the data-final-fixes.lua instead of data-updates.lua. This will make mod work properly with bobplates for example.

Re: [MOD 0.12.X] Big Bags 1.0.7

Posted: Fri Apr 29, 2016 6:37 pm
by binbinhfr
Ok, hope noone will create items in data-final-fixes.lua, or we're done ! :)
Here is v1.0.7

Re: [MOD 0.12.X] Big Bags 1.0.7

Posted: Fri Apr 29, 2016 6:41 pm
by orzelek
Is it by design that some item types have the stack size modified twice?

It's evident now when using multiplier - there are separate for loops that iterate ammo/modules/capsules but they were already iterated by main loop.

One more proposal from me - add option to disable ammo from stack size increases. It kind of multiplies with magazine capacity increase.

Re: [MOD 0.12.X] Big Bags 1.0.7

Posted: Fri Apr 29, 2016 7:31 pm
by binbinhfr
orzelek wrote:Is it by design that some item types have the stack size modified twice?

It's evident now when using multiplier - there are separate for loops that iterate ammo/modules/capsules but they were already iterated by main loop.

One more proposal from me - add option to disable ammo from stack size increases. It kind of multiplies with magazine capacity increase.
Please give me an example of object stack counted twice. I do not see.

For the ammo stack, I prefer to keep it this way : especially when you have a lots of turrets to feed, ammos can take a lot of place/room in chest/bags. So I need this feature. ;)
But you are free to edit the code for yourself, of course.

Re: [MOD 0.12.X] Big Bags 1.0.7

Posted: Fri Apr 29, 2016 8:02 pm
by orzelek
Do a small test:
Set stack multiplier to 3 and run the game.
Usual item stacks like plates will be x3 but ammo stack will be x9.

Re: [MOD 0.12.X] Big Bags 1.0.7

Posted: Fri Apr 29, 2016 9:17 pm
by binbinhfr
Yes, I did not notice that when I first wrote this mod a while ago. Maybe something changed.
Anyway, I corrected it, now ammo are not modified twice. So their stack becomes more reasonable :D

Here is v1.0.8
Corrects double modification of ammo stack.

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 4:10 am
by Ytm
how about sandbox? It seems that in this scenario "Big Bags" does not work

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 7:02 am
by binbinhfr
Ytm wrote:how about sandbox? It seems that in this scenario "Big Bags" does not work
Bigbags only works on a real character's player.
When you are in sandbox, you do not have a character, your are in god mode, flying all around.
God's mode inventory size is not editable as dev said in this post.
Sorry. ;)

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 8:11 am
by Therkaz
When starting the game with your mod enabled, I get the following error:

data-final-fixes.lua:19: attempt to compare number with strings

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 12:03 pm
by binbinhfr
Therkaz wrote:When starting the game with your mod enabled, I get the following error:
data-final-fixes.lua:19: attempt to compare number with strings
Strange. Did you edit the code by yourself ? What are the other mods you are running ?
Does anyone else gets this error ?

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 1:00 pm
by kunkka
Hello!

Thanks for the great mod!

How can I add more logistics slot? I want to keep the vanilla stack sizes but double the inventory / logistic slots / logistic trash sizes (like on the mod screenshot).
I can't find this in the config file and with the mod installed I have only the default slot number except the inventory.

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 2:15 pm
by binbinhfr
kunkka wrote:Hello!

Thanks for the great mod!

How can I add more logistics slot? I want to keep the vanilla stack sizes but double the inventory / logistic slots / logistic trash sizes (like on the mod screenshot).
I can't find this in the config file and with the mod installed I have only the default slot number except the inventory.
You don't have to edit the files.

You have to make the corresponding researches of the next tiers in your research panel, and everything will appear. But it's not free ! :D

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 2:25 pm
by Therkaz
binbinhfr wrote:
Therkaz wrote:When starting the game with your mod enabled, I get the following error:
data-final-fixes.lua:19: attempt to compare number with strings
Strange. Did you edit the code by yourself ? What are the other mods you are running ?
Does anyone else gets this error ?
No, I didn't change anything on the code. My other mods are: air-filtering and Yuoki

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sun May 01, 2016 2:41 pm
by binbinhfr
Therkaz wrote: No, I didn't change anything on the code. My other mods are: air-filtering and Yuoki
Air-filtering does not seem to interfere.

Yuoki creates the error :
In one of its lua module, yuoki writes
data.raw["item"]["stone"].stack_size="100"
It should be an integer, not a string, that's what it is interfering with my mod.
I just asked Yuoki why he wrote that way, if it's a trick or if it's an error.

For the moment and untill his answer, please replace this file :
data-final-fixes.lua
(1.5 KiB) Downloaded 202 times
but note that all resources stack (coal, stone, ores) will be fixed to 100.

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Mon May 02, 2016 2:37 pm
by Therkaz
binbinhfr wrote:
Therkaz wrote: No, I didn't change anything on the code. My other mods are: air-filtering and Yuoki
Air-filtering does not seem to interfere.

Yuoki creates the error :
In one of its lua module, yuoki writes
data.raw["item"]["stone"].stack_size="100"
It should be an integer, not a string, that's what it is interfering with my mod.
I just asked Yuoki why he wrote that way, if it's a trick or if it's an error.

For the moment and untill his answer, please replace this file :
data-final-fixes.lua
but note that all resources stack (coal, stone, ores) will be fixed to 100.
That worked. Thanks!

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Mon May 02, 2016 2:43 pm
by binbinhfr
Therkaz wrote:That worked. Thanks!
Yuoki is looking at his code to see if he can correct the problem in a cleaner way.

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Wed May 04, 2016 12:33 pm
by binbinhfr
Yuoki just PM me that he released a new version with the needed correction. So you should download his v0.2.45 .

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sat May 28, 2016 9:05 am
by MiniMe943
Whenever I try changing the config to use the option that doesn't change stack sizes, i.e. my_stack_offset = 0 and my_stack_factor = 1, I get an error saying "data-final-fixes.lua.5: attempt to perform arithmetic on local 'factor' (a nil value)".

Re: [MOD 0.12.X] Big Bags 1.0.8

Posted: Sat May 28, 2016 11:08 am
by binbinhfr
MiniMe943 wrote:Whenever I try changing the config to use the option that doesn't change stack sizes, i.e. my_stack_offset = 0 and my_stack_factor = 1, I get an error saying "data-final-fixes.lua.5: attempt to perform arithmetic on local 'factor' (a nil value)".
Hi,

it works for me...
did you comment/uncomment the right lines ? like this :

Code: Select all

my_inventory_size = 170       -- should be a multiple of 10

-- changes stack size for every item
-- (formula : new_stack_size = my_stack_offset + my_stack_factor * old_stack_size)

-- my_stack_offset = 0	   		-- multiply every stack size by 10
-- my_stack_factor = 10	  	

-- my_stack_offset = 500	-- set every stack size to 500 (old setting in v1.0.5)
-- my_stack_factor = 0			 

-- my_stack_offset = 100	-- multiply every stack size by 5 and add 100
--- my_stack_factor = 5  	

my_stack_offset = 0		-- does not change anything
my_stack_factor = 1  	

-- changes default magazine size for every ammo
my_mag_offset = 0             
my_mag_factor = 10			 

my_default_req_amount = 1	  -- to change default request amount in character logistic slots

my_running_speed_factor = 1   -- multiplicative factor, if > 1, your running speed is increased

Plz, tell me if you solve the problem.