Factorio Forums

Keysivi wrote: Thu Dec 26, 2024 8:04 am New batch of errors

In the case of the function 'insert_trigger' in data-final-fixes.lua, there are no more errors, but there was one in control.lua:

Code: Select all

__ElectricPoweredBelts__/control.lua:28: attempt to index global 'util' (a nil value)
stack traceback:
__ElectricPoweredBelts__/control.lua:28: in main chunk

[/code]

Keysivi wrote: Thu Dec 26, 2024 8:04 am In the case of the function 'get_trigger', the error seems to be the same, but now it points to 'insert_trigger'. As far as I understand, the problem is not only in the missing letter 'g'.

Code: Select all

Failed to load the following mods: __ElectricPoweredBelts__/data-final-fixes.lua:33: attempt to call global 'insert_trigger' (a nil value)
stack traceback:
__ElectricPoweredBelts__/data-final-fixes.lua:33: in main chunk

Keysivi wrote: Thu Dec 26, 2024 8:04 am I also took the liberty of replacing:

Code: Select all

return tbl[field][1]
end

with:

Code: Select all

end
return tbl[field][1]

It didn't change anything though...

1. I added the loop that starts with 'for _, v in pairs{data.raw["artillery-turret"]["artillery-turret"],' to data-final-fixes.lua, it was adapted from the code you posted at the start of this thread with the following changes:
   • I removed the energy_per_shot = "8kJ" as that does nothing
   • I removed the local x you where passing to data:extend as I don't know why it was there
   • I removed energy_usage as it seems redundant with drain
   • I made the loop operate specifically on the artillery and flamethrower turrets
2. I uncommented the insert_trigger function and put it before the first loop
3. I merged the two "for _, ammo in pairs{data.raw["ammo"]["artillery-shell"]," loops into one by using a single 'if'

1. Sadly I had to re-add the storage.entities table, as for some reason (despite it working in one of my mods), doing storage.power_enitities[event.entity] wasn't working. Now there is a 'local id = event.entity.unit_number' that takes the place of the old 'local pos' (unit_number is supposed to be globally unique, unless you create more than 4,294,967,295 entities...)
2. Where you do 'event.entity.type' I change it to 'event.entity.name' (event.entity.type is the name of the prototype's type, whereas event.entity.name is the prototype's name, e.g. the flamethrower turret has type 'fluid-turret' but name 'flamethrower-turret')
3. I've changed where it says "if event.entity.type == "artillery-shell"", to now say "if event.entity.name== "artillery-turret"" (artillery-shell is the ammo item! not the entity that fires the ammo).
4. To the line starting with 'script.on_event({defines.events.on_entity_died' I added defines.events.on_space_platform_pre_mined (to handle the case where the turret was deconstructed by a space platform, instead of being destroyed by damage, by a robot, or the player).
5. To the line starting with "if turret.disabled_by_script", I changed the 'if' to 'elseif', and added the following before it:

   Code: Select all

   if not turret.valid then
   	interface.destroy()
   	storage.power_entities[id] = nil
   	storage.entities[id] = nil 

   I think this is only necessary if you destroy the turret in the editor, as I couldn't find an event to catch such destructions.

5. To the line starting with "if turret.disabled_by_script", I changed the 'if' to 'elseif', and added the following before it:

Code: Select all

Code: Select all

if not turret.valid then
	interface.destroy()
	storage.power_entities[id] = nil
	storage.entities[id] = nil 

I think this is only necessary if you destroy the turret in the editor, as I couldn't find an event to catch such destructions.

data.raw["fluid-turret"]["flamethrower-turret"].energy_source = {
type = "electric",
buffer_capacity = "1000kJ",
input_flow_limit = "200kW",
usage_priority = "primary-input",
drain = "20kW"
}
data.raw["fluid-turret"]["flamethrower-turret"].energy_per_shot = "10kJ"

data.raw["artillery-turret"]["artillery-turret"].energy_source = {
type = "electric",
buffer_capacity = "2000kJ",
input_flow_limit = "300kW",
usage_priority = "primary-input",
drain = "50kW"
}
data.raw["artillery-turret"]["artillery-turret"].energy_per_shot = "10MJ"

Keysivi wrote: Thu Dec 26, 2024 1:04 pm There is one small bug: If you install turrets through the editor, then an invisible entity "artillery-turret-power" or "flamethower-turret-power" is installed along with them, which remains in their place when the turrets are deleted.

This is not observed when installing turrets directly in the game.

I suspect that this is somehow related to:

5. To the line starting with "if turret.disabled_by_script", I changed the 'if' to 'elseif', and added the following before it:

Code: Select all

if not turret.valid then
	interface.destroy()
	storage.power_entities[id] = nil
	storage.entities[id] = nil 

I think this is only necessary if you destroy the turret in the editor, as I couldn't find an event to catch such destructions.

Keysivi wrote: Thu Dec 26, 2024 1:04 pm I will also have to create two tables instead of your one. because this mod will need to be made compatible with this mod: https://mods.factorio.com/mod/Turrets-n ... rgy-source

And there are different parameters for "artillery-turret" and "flamethower-turret"

data.raw["fluid-turret"]["flamethrower-turret"].energy_source = {
type = "electric",
buffer_capacity = "1000kJ",
input_flow_limit = "200kW",
usage_priority = "primary-input",
drain = "20kW"
}
data.raw["fluid-turret"]["flamethrower-turret"].energy_per_shot = "10kJ"

data.raw["artillery-turret"]["artillery-turret"].energy_source = {
type = "electric",
buffer_capacity = "2000kJ",
input_flow_limit = "300kW",
usage_priority = "primary-input",
drain = "50kW"
}
data.raw["artillery-turret"]["artillery-turret"].energy_per_shot = "10MJ"

I think I can do it myself. But if you want, you can offer a better option.

for v, energy in pairs{
 	[data.raw["artillery-turret"]["artillery-turret"]] =  {
		type = "electric",
		buffer_capacity = "800kJ", 
		input_flow_limit = "100kW",  
		usage_priority = "primary-input",
		drain = "10kW" },
	[data.raw["fluid-turret"]["flamethrower-turret"]] = {
		... }} do -- same as above, but you can use different values

Keysivi wrote: Thu Dec 26, 2024 1:04 pm And the last thing - the data "artillery-turret-power" or "flamethower-turret-power" is not displayed when selecting "artillery-turret" or "flamethower-turret" - is there a way to fix this?

Keysivi wrote: Thu Dec 26, 2024 5:23 pm Firstly, it became impossible to interact with the turret itself, for example, to manually charge it. Plus, it is now impossible to view the data of the turret itself.

selection_box = {{-0.5, -0.5}, {0.5, 0.5}},

Keysivi wrote: Thu Dec 26, 2024 5:23 pm Secondly, an image of a battery was superimposed on top of the turrets.

drawing_box_vertical_extension = template.drawing_box_vertical_extension,
picture = template.picture,

IsaacOscar wrote: Fri Dec 27, 2024 6:31 am Great work! I'll test it soon, in particular, I want to work out the difference between adding the flamethrower trigger to a 'Stream' TrigerDeliver, vs adding it to an 'instant' one.

Keysivi wrote: Sun Dec 29, 2024 12:33 pm

IsaacOscar wrote: Fri Dec 27, 2024 6:31 am Great work! I'll test it soon, in particular, I want to work out the difference between adding the flamethrower trigger to a 'Stream' TrigerDeliver, vs adding it to an 'instant' one.

Good day! So how is the mod? Have you tried it yet?

IsaacOscar wrote: Sun Dec 29, 2024 12:36 pm Sorry! Was lazy, busy, and sick. And then I was working on my own mods (I now have 9!)
I'll look at it tomorrow!

1. The electric energy interface now has what I consider a nicer name and position, and it should work with all languages (not just English and Russian):
   English

   

   Screenshot 2024-12-30 173825.png (188.87 KiB) Viewed 672 times

   

   Screenshot 2024-12-30 173846.png (168.78 KiB) Viewed 672 times

   Russian

   

   Screenshot 2024-12-30 174742.png (169.73 KiB) Viewed 672 times

   

   Screenshot 2024-12-30 174759.png (160.03 KiB) Viewed 672 times

2. Flamethrower turrets now consume energy every time the stream hits an enemy, as opposed to everytime they start firing the stream. For example, this means if it starts firing but doesn't hit anything (e.g. the target moved away, or was killed by something else first), it won't consume any energy. But if the turret gets attacked by a swarm, and it sends a constant stream to kill them all, it will use a lot of energy, and not just one 'shot' worth (as it was doing before). If you have another idea for when it should use energy, let me know. (Personally, I think having it consume energy for every tick that it is shooting would be the best, but that will likely be performance heavy, and I'm not actually sure how to do that).
3. You can now load the mod on existing saves, any turrets that were built before the mod was activated will now require electricity, just as if they were built after loading the mod.

Keysivi wrote: Sun Dec 29, 2024 3:10 pm I also have a small question about Unquality https://mods.factorio.com/mod/unquality . Am I right in understanding that the developers' idea with "Quality" is not the best. Because I paid attention to this mod, but I doubted - how relevant is it?

• Unintended extra click when setting up recipes due to the "Quality" dropdown. (11752)
• Allow us to make rocket parts with quality components OR give as a method to lower quality of resources (120353, I've made a mod that fixes this!)
• More Exciting Quality Effects (pls) (118785, basically there are many stats in the game that are not effected by quality, making many quality buildings practically useless)
• Ability to craft lower quality with higher quality (116817, otherwise you need to build a whole smart recycling setup to really benefit from quality)
• Have quality seeds grow quality plants (121647)
• Output more fluid when using higher quality recipes (i.e. for Holmium Solution) (120829, for some reason you can use quality ingredients in a lot of fluid recipes, but it's a total waste)
• Add more ways for quality to affect items (120398)
• Tiles ignore quality (122146, putting quality tiles down destroys the quality!)
• fish placed in water lose their quality (119548, you can't keep quality fish fresh in water, as they will lose their quality!)
• (lots of people were also complaining about the names of the quality levels, even before it got released!, e.g. 108777, so I'm very surprised the developers didn't change them, maybe they just couldn't decide which set of names to change them to).

IsaacOscar wrote: Mon Dec 30, 2024 8:14 am As for publishing the mod, I'd prefer if you did it as it was you're idea, and I'm trying to only make mods for things I think should be in Factorio Vanilla.

And a completely unrelated thing I noticed when testing that it worked in Russian, the name of the space-age mod isn't translated to russian (although the description is), perhaps you can fix this on https://crowdin.com/project/factorio or post a bug report? (I don't know Russian so I don't know what it should say!).

Keysivi wrote: Wed Jan 08, 2025 6:46 pm Hello! I found one nasty bug. Unfortunately, the mod does not work in case of modified shells.

Keysivi wrote: Wed Jan 08, 2025 6:46 pm Can I register these shells through "or"? For example, like this:

Code: Select all

for _, obj in pairs{data.raw["ammo"]["artillery-shell" or "napalm-artillery-shell" or "atomic-artillery-shell" or "poison-artillery-shell"].ammo_type, data.raw["stream"]["flamethrower-fire-stream"]} do
	local action = get_trigger(obj, "action", {type = "direct"})
	local action_delivery = get_trigger(action, "action_delivery", {type = "instant"})
	insert_trigger(action_delivery, "source_effects", {type = "script", effect_id = "turret-consume-energy"}) end

Keysivi wrote: Wed Jan 08, 2025 6:46 pm Or will it be necessary to write a more detailed script there?

local ammos = {data.raw["stream"]["flamethrower-fire-stream"]}

for _, a in pairs(data.raw["ammo"]) do
	if a.ammo_category == "artillery-shell" then
		table.insert(ammos, a.ammo_type) end end

for _, obj in pairs(ammos) do
	-- the rest is the same code as before
local action = get_trigger(obj, "action", {type = "direct"})
	local action_delivery = get_trigger(action, "action_delivery", {type = "instant"})
	insert_trigger(action_delivery, "source_effects", {type = "script", effect_id = "turret-consume-energy"}) end

IsaacOscar wrote: Thu Jan 09, 2025 12:20 pm

Keysivi wrote: Wed Jan 08, 2025 6:46 pm Hello! I found one nasty bug. Unfortunately, the mod does not work in case of modified shells.

Not technically a 'bug' as I was not trying to make it work with mods.