Factorio Forums

sillyfly wrote:Do you know if Allegro supports Unicode control characters? I really don't know how widespread the support for these is.

Anyway, if the chosen method of support will indeed be deploy scripts, they can always use fribidi which does a good job even without such characters: http://fribidi.org/ (LGPL)

MF- wrote:

jockeril wrote: If I understand you correctly, then it's the other way around - the text in the locale files is visually ok - but the game re-arranges it logically and that messes up the visual...

I thought factorio simply doesn't support RTL / BiDi.
So a "logical" RTL format will appear allright in the text editor, but will be presented "in byte order" in-game.
note: You know that technically there is a "RTL" unicode symbol, followed by character is reading order, right?

You workaround currently seems to be converting to "visual" ordering, where byte order is "left to right"
so there is no RTL marker and text might appear (but edit weirdly) right both in the text editor and in game.

Obviously a step forward would be using "logical" for the editing step, but then convert it to "visual" for the game.
That way the odd "visual" ordering will be limited to the internals of the game.
And I belive the factorio deploy scripts should be able to take care of that conversion.

sillyfly wrote:Allegro is the gaming/graphics engine that Factorio uses. If it doesn't support Unicode direction markers then MF-'s suggestion probably won't work.

jockeril wrote: I appreciate your explanation but all it's done, since I'm not a programmer, is confuse me about the difference between "logical" and "visual" representation of the text, and again - using scripts is not something I can do.

I hope the #dev team will sometime soon allocate the resources needed to make the changes so I don't have to continue translating & inverting the locale files text for the game.

FYI (1) - it turned out to not just be a matter of inverting text but also adjusting some of the original translation and the combination of hebrew & English in a sentence to appear correctly on screen. This is the reason it's not finished yet.

FYI (2) - Trying to use GitHub to publicly deliver the mod to the masses , I'm having problems uploading my local files to the repository... still learning how to work with that

Dev-iL wrote:So I wrote a very basic python script that inverts all strings after "=" in a core.cfg file located in the same folder as the script:

Code: Select all

#!/usr/bin/python
# coding=utf-8

import codecs


def main():
    f_out = codecs.open('core_out.cfg', 'a+', encoding='utf8')
    with codecs.open('core.cfg', 'r', encoding='utf8') as f:
        for line in f:
            if line[0] in ["[", "\n"]:
                f_out.write(line)
                continue

            split_ln = line.split('=')
            eng_part = split_ln[0]
            heb_part = split_ln[1].strip()  # removing the newline at the end 
            tokens = list(reversed(heb_part.split(' ')))
            for ind, token in enumerate(tokens, 0):
                if not token:  # skip empty lines
                    continue
                if not all(ord(c) < 128 for c in token):  # (supposed to) skip non-heb tokens 
                    token = token[::-1]
                tokens[ind] = token
            f_out.write(eng_part + u"=\u200F" + ' '.join(tokens) + '\n')  # the RTL character is added after the '='
    f_out.close()

if __name__ == "__main__":
    main()
    print "\n!!! Don't forget to fix the font names @ line ~222 !!!"

Then I placed it in the mods folder as needed and got the following result:


For some reason "Multisampling" got inverted too .

In any case, I'm attaching my mod-attempt to this post.

jockeril wrote:And in that, you've just solved the whole RTL issue ! thank you very much

two questions:
1. what's with the text about line 222 font names ?
2. can you expand this to all the locale files in the game ?

also, I've noticed a problem with my "mod" that makes the game crash (and I reported it) for some unknown reason. I'll have the devs look at it anyway to insure that it's not a problem to other mods

[font]
default=locale/he/Arimo.ttf
default-semibold=locale/he/Arimo.ttf
default-bold=locale/he/Arimo-Bold.ttf

sillyfly wrote:Why re-invent the wheel?
https://pypi.python.org/pypi/python-bidi

#!/usr/bin/python
# coding=utf-8

import codecs
import os
import glob
import sys

OUTPUT_FOLDER_NAME = "output"
DEFAULT_FILE_EXT = "cfg"


def main(input_file_ext=DEFAULT_FILE_EXT):
    # Initialize output folder:
    if not os.path.exists(OUTPUT_FOLDER_NAME):
        os.makedirs(OUTPUT_FOLDER_NAME)
    else:
        clear_folder(OUTPUT_FOLDER_NAME)

    # Obtain list of all files that need processing:
    for filename in glob.glob('*.' + input_file_ext):
        f_in = codecs.open(filename, 'r', encoding='utf8')
        f_out = codecs.open(os.path.join(OUTPUT_FOLDER_NAME, ''.join([filename[:-3], DEFAULT_FILE_EXT])),
                            'a+', encoding='utf8')
        for line in f_in:
            # Skip empty lines or lines where sections begin:
            if line[0] in ["[", "\n", "\r"]:
                f_out.write(line)
                continue

            split_ln = line.split('=')
            eng_part = split_ln[0]
            heb_part = split_ln[1].strip()  # removing the newline at the end
            tokens = list(reversed(heb_part.split(' ')))
            for ind, token in enumerate(tokens, 0):
                if not token:  # skip empty lines
                    continue
                if not all(ord(c) < 128 for c in token):  # (supposed to) skip non-heb tokens
                    # rotate parentheses
                    if token[0] is '(':
                        token = ')' + token[1:]
                    if token[-1] is ')':
                        token = token[:-1] + '('
                    token = token[::-1]
                tokens[ind] = token
            if all(ord(c) < 128 for c in line):
                f_out.write(line)  # Supposed to fix the inverted fonts issue
            else:
                f_out.write(eng_part + u"=\u200F" + ' '.join(tokens) + '\r\n')
                # Note the RTL character, \u200F, that is added after the '='
        # Close files
        f_in.close()
        f_out.close()

def clear_folder(path):
    for root, dirs, files in os.walk(path, topdown=False):
        for name in files:
            os.remove(os.path.join(root, name))
        for name in dirs:
            os.rmdir(os.path.join(root, name))

if __name__ == "__main__":
    if len(sys.argv) == 2 and len(sys.argv[1]) == 3:  # The 0th input is the script name, so we ignore it
        main(input_file_ext=sys.argv[1])
    else:
        main()  # read .cfg files by default

python nameOfScript.py "ini"
-- OR --
python nameOfScript.py   <= by default assumes "cfg"

MF- wrote:So it might be crashing only for you?
Did you try it on a fresh factorio copy of both factorio data and configuration?

EDIT: Oh, you already did that in the Laptop thread.

cube wrote:I added a functionality very simillar to Dev-iL's script to 0.12.1. It's definitely not perfect, and there will be issues with line wrapping strings, but it's better than nothing.

Dev-iL wrote:I've uploaded my mod in the mods section of the forum. Here's a link to its thread.