[1.0.0] Mod doesn't sync with save properly if the mod acquired new dependencies

We are aware of them, but they have low priority. We have more important things to do. They go here in order not to take space in the main bug thread list.
Post Reply
curiosity
Burner Inserter
Burner Inserter
Posts: 8
Joined: Wed Sep 11, 2019 4:13 pm
Contact:

[1.0.0] Mod doesn't sync with save properly if the mod acquired new dependencies

Post by curiosity »

Steps to reproduce:
1. Make an installation of the game with attached mods (truncated for size) and save.
2. Start the game, ensure that all mods are disabled. Sync mods with save.
3. Observe that Factory Planner isn't loaded.
4. Sync mods with save again. Note that it offers to download Factory Planner.
5. Observe that Factory Planner still isn't loaded.

I believe, this happens because Factory Planner started requiring flib, which I already have in my mods disabled. The game enables Factory Planner, but doesn't check any dependencies. You can see that the mod is red in the mod manager.

I would have expected the game to enable any required dependencies when enabling mods, same as it happens when you enable a mod manually.
Attachments
mods.zip
(601.27 KiB) Downloaded 7 times
seablock.zip
(5.24 MiB) Downloaded 5 times

Impatient
Filter Inserter
Filter Inserter
Posts: 635
Joined: Sun Mar 20, 2016 2:51 am
Contact:

Re: [1.0.0] Mod doesn't sync with save properly if the mod acquired new dependencies

Post by Impatient »

I just ran into the same issue and can confirm it.

I may have easier steps to reproduce:

1. Make a new savegame with mod "Picker Dollies" and mod "Factorio Standard Library" enabled.
2. Disable mod "Factorio Standard Library" -> Restart
3. Click sync mods with save on the created savegame.

Notice that mod "Picker Dollies" is listed as "Ready to download", although what it needs is it's dependency, mod "Factorio Standard Library", to be met by activating it.

Rseding91
Factorio Staff
Factorio Staff
Posts: 11363
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.0.0] Mod doesn't sync with save properly if the mod acquired new dependencies

Post by Rseding91 »

I know why this happens but "solving" it is one of the biggest annoyances in the downloading mods logic. It basically has to recursively download info about each mod and its dependencies until it stops having more or it recourses back onto an already downloaded mod. If the 2nd happens then the whole thing just blows up and fails.

There's no nice solution to it. Maybe making sync-mods-with-save download the specific version that was in the save to prevent it...
If you want to get ahold of me I'm almost always on Discord.

Post Reply

Return to “Minor issues”

Who is online

Users browsing this forum: No registered users