[1.1.62] Freezing in multiplayer

[Thebri]

Hi!

For the first time in my many years an thausands of hours in playing Factorio we had real issues yesterday.
After updating to 1.1.62 both my friend that were connected to me got the same problem multiple times in our 2 hour session:

Factorio on their side just froze up. They could not do anything other then using the task manager to close the game. Meanwhile they were beeing dropped from my game.

I can not give much more information and we have no bug reports or something.

Just a heads up.

Regards
Thebri

[Thebri]

After this happened today in single player to myself and a friend with different maps and mods installed I tried to investigate more.

Using Factorio 1.1.61 is fine
When using 1.1.62 or 1.1.63 and walking to or looking via map at a place where "nexelit powered accumulator MK1" from Pyanodons are placed the game is frozen instantly. But can not be closed normally, sounds are playing for a while and in the task manager there is no GPU module listed anymore, but in my machine 8% of processor power is still used by Factorio.exe
I am using the same mods and mod versions for all Factorio versions.

[boskid]

Description is quite accurate (except of specifying which exact mod from Pyanodons has this entity) so i was able to reproduce the issue in [1.1.63] with the following save file:

save file

102991-reproduction.zip

(212.18 KiB) Downloaded 79 times

1/ Sync mods with save
2/ Load
3/ Run time: a freeze will happen

From looking at where it freezes, it is something between SDL_Mixer library and vorbis library when trying to load a sound file __pyindustry__/sounds/accumulator.ogg

call stack

Code: Select all

 	[Inline Frame] factorio-run.exe!_seek_helper(OggVorbis_File *) Line 83	C
>	[Inline Frame] factorio-run.exe!_get_prev_page(OggVorbis_File *) Line 157	C
 	factorio-run.exe!ov_pcm_seek_page(OggVorbis_File * vf, __int64 pos) Line 1546	C
 	factorio-run.exe!ov_pcm_seek(OggVorbis_File * vf, __int64 pos) Line 1593	C
 	factorio-run.exe!ov_time_seek(OggVorbis_File * vf, double seconds) Line 1714	C
 	[Inline Frame] factorio-run.exe!OGG_Seek(void *) Line 405	C
 	factorio-run.exe!OGG_Play(void * context, int play_count) Line 319	C
 	factorio-run.exe!Mix_LoadMusic_RW(Mix_MusicType music_type, SDL_RWops * src, int freesrc, SDL_AudioSpec * spec, unsigned char * * audio_buf, unsigned int * audio_len) Line 658	C
 	factorio-run.exe!Mix_LoadWAV_RW(SDL_RWops * src, int freesrc) Line 784	C
 	factorio-run.exe!SampleSDL::load() Line 27	C++
 	[Inline Frame] factorio-run.exe!SoundLibrary::loadItem(SoundLibrary::Item &) Line 166	C++

[Thebri]

Thank you for providing the save game - I was just working on making a small one myself.

[Rseding91]

This is super weird, the audio plays fine in older versions of the game. But, what's even weirder is: when I try to play it in windows media player, or media player classic it won't play. All the other sounds from the mod play correctly just the one accumulator.ogg does not.

[Thebri]

I testes some more:

Foobar2000 is not playing the file accumulator.ogg either.
Ogginfo says

Code: Select all

Processing file "accumulator.ogg"...

New logical stream (#1, serial: 6e380078): type theora
New logical stream (#2, serial: e30f2e62): type vorbis
Theora headers parsed for stream 1, information follows...
Version: 3.2.1
Vendor: Lavf56.25.101
Width: 256
Height: 256
Total image: 256 by 256, crop offset (0, 0)
Framerate 90000/1 (90000,00 fps)
Pixel aspect ratio 1:1 (1,000000:1)
Frame aspect 1,000000:1
Colourspace unspecified
Pixel format 4:2:0
Target bitrate: 0 kbps
Nominal quality setting (0-63): 37
User comments section follows...
        title=
        DESCRIPTION=Cover (front)
        encoder=Lavc56.28.100 libtheora
        TIT1=Sound Ideas
        TOWN=The Library
        genre=INDUSTRY, POWER PLANT
        copyright=2014The Library
        publisher=Sound Ideas
        TIT3=All Sound Effects & Music are Copyright Sound Ideas - All Rights Reserved
        date=2014
        artist=The Library
        TOAL=www.sound-ideas.com
        TRACKNUMBER=0
        TLEN=117272
Vorbis headers parsed for stream 2, information follows...
Version: 0
Vendor: Lavf56.25.101
Channels: 2
Rate: 44100

Nominal bitrate: 160,000000 kb/s
Upper bitrate not set
Lower bitrate not set
User comments section follows...
        encoder=Lavc56.28.100 libvorbis
        TIT1=Sound Ideas
        TOWN=The Library
        genre=INDUSTRY, POWER PLANT
        copyright=2014The Library
        publisher=Sound Ideas
        TIT3=All Sound Effects & Music are Copyright Sound Ideas - All Rights Reserved
        date=2014
        artist=The Library
        TOAL=www.sound-ideas.com
        TRACKNUMBER=0
        title=IndustryPowerPlant TL04_60
        TLEN=117272
Theora stream 1:
        Total data length: 5430 bytes
        Playback length: 0m:00.000s
        Average bitrate: inf kb/s
Logical stream 1 ended
Vorbis stream 2:
        Total data length: 2307487 bytes
        Playback length: 1m:57.400s
        Average bitrate: 157,239197 kb/s
Logical stream 2 ended

I have no idea what this means...

But for testing purposes I just have deleted the file, copied accumulator-mk02.ogg to accumulator.ogg and now the freeze is gone.

I think the mod needs to be updated, but also Factorio should exit gracefully when encountering a broken sound file.

Rezipped everything and it works now.

[lyvgbfh]

I've re-encoded the file and put a fixed version on the mod portal. It would still be good to see this treated as a regression, but at least now it should affect less users.

[BlueTemplar]

Link please ?

Looks like it might have been caused by the file also having a video stream ?

(And I wonder why only rare people get this issue ??)

[Gergely]

Has anyone got any tips how to workaround this? When I try to convert (for example) one of the FLAC files in the Factorio Soundtrack, ffmpeg will generate the "video stream" of the (outdated) disc cover art even if video is explicitly disabled. VLC media player DOES read and display this video stream out of the file, so it could be helpful.

[Rseding91]

Can you post a broken ogg so I can poke at it again?

[Gergely]

Can you post a broken ogg so I can poke at it again?

Here it is.

broken-ogg.zip

(1.58 MiB) Downloaded 56 times