Carry over custom inserter pickup/drop when upgrading/fast replacing

Suggestions that were added to the game.

Moderator: ickputzdirwech

Post Reply
GotLag
Filter Inserter
Filter Inserter
Posts: 532
Joined: Sat May 03, 2014 3:32 pm
Contact:

Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by GotLag »

Currently, manually fast-replacing or using the upgrade planner on an inserter results in the upgraded inserter reverting to the prototype's pickup_position and drop_position.

I'd like to suggest that when an inserter is fast-replaced or upgraded, if the prototypes allow custom vectors then the pickup/drop should be carried over, in the same way that circuit conditions are copied.

Naturally I want this for the benefit of Side Inserters, but other mods like Bob's Adjustable Inserters would benefit as well.

mrvn
Smart Inserter
Smart Inserter
Posts: 4475
Joined: Mon Sep 05, 2016 9:10 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by mrvn »

GotLag wrote:
Fri Mar 08, 2019 1:02 pm
Currently, manually fast-replacing or using the upgrade planner on an inserter results in the upgraded inserter reverting to the prototype's pickup_position and drop_position.

I'd like to suggest that when an inserter is fast-replaced or upgraded, if the prototypes allow custom vectors then the pickup/drop should be carried over, in the same way that circuit conditions are copied.

Naturally I want this for the benefit of Side Inserters, but other mods like Bob's Adjustable Inserters would benefit as well.
Note: The Upgrade planner mod handled that correctly. So this is a regression with the upgrade planner being added to vanilla.

User avatar
ickputzdirwech
Filter Inserter
Filter Inserter
Posts: 638
Joined: Sun May 07, 2017 10:16 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by ickputzdirwech »

I am 99.9% certain they fixed this issue. Can’t test it in vanilla obviously but it certainly doesn’t exist in Bob’s adjustable inserters anymore.
Mods: Shortcuts for 1.1, ick's Sea Block, ick's vanilla tweaks
Tools: Atom language pack
Text quickly seems cold and unfriendly. Be careful how you write and interpret what others have written.
- A reminder for me and all who read what I write

GotLag
Filter Inserter
Filter Inserter
Posts: 532
Joined: Sat May 03, 2014 3:32 pm
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by GotLag »

You might want to start looking at the dates on these threads before replying.

Bilka
Factorio Staff
Factorio Staff
Posts: 2790
Joined: Sat Aug 13, 2016 9:20 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by Bilka »

ickputzdirwech wrote:
Sat Apr 10, 2021 10:57 am
I am 99.9% certain they fixed this issue. Can’t test it in vanilla obviously but it certainly doesn’t exist in Bob’s adjustable inserters anymore.
Yes, 65462 / 86982
I'm an admin over at https://wiki.factorio.com. Feel free to contact me if there's anything wrong (or right) with it.

User avatar
ickputzdirwech
Filter Inserter
Filter Inserter
Posts: 638
Joined: Sun May 07, 2017 10:16 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by ickputzdirwech »

GotLag wrote:
Sat Apr 10, 2021 10:58 am
You might want to start looking at the dates on these threads before replying.
I do. Doesn't change that they are implemented.
Mods: Shortcuts for 1.1, ick's Sea Block, ick's vanilla tweaks
Tools: Atom language pack
Text quickly seems cold and unfriendly. Be careful how you write and interpret what others have written.
- A reminder for me and all who read what I write

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2384
Joined: Fri Nov 06, 2015 7:41 pm

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by Deadlock989 »

Well, let us know when you're done personally reorganising 350 pages of forum suggestions from multiple years ago, and then the rest of us can start using the forum again.
Last edited by Deadlock989 on Sat Apr 10, 2021 11:01 am, edited 1 time in total.
"If Stalin had a good writeup on programming, would linking that be dangerous?"

User avatar
ickputzdirwech
Filter Inserter
Filter Inserter
Posts: 638
Joined: Sun May 07, 2017 10:16 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by ickputzdirwech »

Already down to 349 :mrgreen:
Mods: Shortcuts for 1.1, ick's Sea Block, ick's vanilla tweaks
Tools: Atom language pack
Text quickly seems cold and unfriendly. Be careful how you write and interpret what others have written.
- A reminder for me and all who read what I write

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5201
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by eradicator »

ickputzdirwech wrote:
Sat Apr 10, 2021 11:01 am
Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
ickputzdirwech
Filter Inserter
Filter Inserter
Posts: 638
Joined: Sun May 07, 2017 10:16 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by ickputzdirwech »

As you can read here, ssilk prefers it if you point it out in the thread directly. But I am happy to change the way I do it, if he asks me to.

Don't you get annoyed if you search for something and 10-20% of the results are already implemented or duplicates of one another? True sorting it will take a lot of time, but you will never finish if you don't start.
Mods: Shortcuts for 1.1, ick's Sea Block, ick's vanilla tweaks
Tools: Atom language pack
Text quickly seems cold and unfriendly. Be careful how you write and interpret what others have written.
- A reminder for me and all who read what I write

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5201
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by eradicator »

ickputzdirwech wrote:
Sat Apr 10, 2021 3:00 pm
Don't you get annoyed if you search for something and 10-20% of the results are already implemented or duplicates of one another? True sorting it will take a lot of time, but you will never finish if you don't start.
I'm not saying that you should stop doing what you're doing. Infact I think it's a commendable effort. But the way you're doing it disturbs normal forum functionality for everyone else and @ssilk probably just didn't think of that either. Maybe if you make a seperate report thread for it? That way other people can join the effort if they want and if @ssilk subscribes to the thread he automatically gets notified of new entries. And he (or other moderators) could even edit posts to mark which reports have been dealt with.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
ptx0
Smart Inserter
Smart Inserter
Posts: 1085
Joined: Wed Jan 01, 2020 7:16 pm
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by ptx0 »

eradicator wrote:
Sat Apr 10, 2021 1:03 pm
ickputzdirwech wrote:
Sat Apr 10, 2021 11:01 am
Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.
you're not a moderator.
My Mods - Fish Per Minute base size metric - Use your crashed spaceship as a belt balancer?
• • •
Base: Bob's @ 1 Million SPM
• • •
Linear search and overflows are indicative of sloppy coding practices.

User avatar
jodokus31
Smart Inserter
Smart Inserter
Posts: 1229
Joined: Sun Feb 26, 2017 4:13 pm
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by jodokus31 »

ptx0 wrote:
Sun Apr 11, 2021 11:47 am
eradicator wrote:
Sat Apr 10, 2021 1:03 pm
ickputzdirwech wrote:
Sat Apr 10, 2021 11:01 am
Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.
you're not a moderator.
Does it matter, if the point is good?

User avatar
ickputzdirwech
Filter Inserter
Filter Inserter
Posts: 638
Joined: Sun May 07, 2017 10:16 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by ickputzdirwech »

ptx0 wrote:
Sun Apr 11, 2021 11:47 am
eradicator wrote:
Sat Apr 10, 2021 1:03 pm
ickputzdirwech wrote:
Sat Apr 10, 2021 11:01 am
Already down to 349 :mrgreen:
Tuning in on the "please stop it". You're completely ruining the "active topics" page and thread activity markers for hundreds of other users. Please just compile a list of implemented threads and send it to @ssilk (or whoever) as a private message. Or use the report feature. Be respectful of other users who want to use this forum too.
you're not a moderator.
No offence taken. A solution is beeing worked on. In the meantime some of you might be interested in reading this topic: 73634.

As you can read there I understand your concerns and I support eradicators idea of a separate report thread.
Mods: Shortcuts for 1.1, ick's Sea Block, ick's vanilla tweaks
Tools: Atom language pack
Text quickly seems cold and unfriendly. Be careful how you write and interpret what others have written.
- A reminder for me and all who read what I write

User avatar
ssilk
Global Moderator
Global Moderator
Posts: 12253
Joined: Tue Apr 16, 2013 10:35 pm
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by ssilk »

Indeed, I didn’t think of that :oops: , report feature is of course the right way to do it, especially for the older topics. My fault, sorry for inconvinience.

The problem is notified, we are working for it in the background. :)

PS: If we continue to have such great progress we will clear the suggestions-board just within the next 3-4 years. Hopefully Factorio II isn't out at that time, so we can handle all the new suggestions.  🤪 :)
Cool suggestion: Eatable MOUSE-pointers.
Have you used the Advanced Search today?
Need help, question? FAQ - Wiki - Forum help
I still like small signatures...

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5201
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Carry over custom inserter pickup/drop when upgrading/fast replacing

Post by eradicator »

ickputzdirwech wrote:
Sun Apr 11, 2021 12:03 pm
No offence taken. A solution is beeing worked on.
Thank you. For the effort, for working on a solution, and especially for not taking offence - a rare trait these days.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Post Reply

Return to “Implemented Suggestions”