Page 2 of 2

Re: Assembling-machine with built-in productivity

Posted: Sun Jul 14, 2019 12:20 pm
by Rseding91
Optera wrote:
Sun Jul 14, 2019 6:42 am
Boodals wrote:
Sat Jul 13, 2019 10:36 pm
I implemented this as a pull request a while ago (I have source access), and it was just accepted. It should be in 0.17.57. Pretty lucky too, I thought the devs wouldn't accept it until 0.18.

Added base_productivity to assembling machines, mining drill, and lab prototypes.
Added LuaEntityPrototype::base_productivity read.
To me this reads as if the productivity value was only writable in data stage, or does this allow creating an assembler based entity gaining productivity from research like mining drills.
Just data stage. Like setting the speed of an assembling machine you can now set the base productivity.

Re: Assembling-machine with built-in productivity

Posted: Sun Jul 14, 2019 12:30 pm
by Optera
Rseding91 wrote:
Sun Jul 14, 2019 12:20 pm
Optera wrote:
Sun Jul 14, 2019 6:42 am
Boodals wrote:
Sat Jul 13, 2019 10:36 pm
I implemented this as a pull request a while ago (I have source access), and it was just accepted. It should be in 0.17.57. Pretty lucky too, I thought the devs wouldn't accept it until 0.18.

Added base_productivity to assembling machines, mining drill, and lab prototypes.
Added LuaEntityPrototype::base_productivity read.
To me this reads as if the productivity value was only writable in data stage, or does this allow creating an assembler based entity gaining productivity from research like mining drills.
Just data stage. Like setting the speed of an assembling machine you can now set the base productivity.
Too bad, guess we can't get rid of hidden beacons yet.

Re: Assembling-machine with built-in productivity

Posted: Mon Jul 15, 2019 11:49 am
by eradicator
Boodals wrote:
Sat Jul 13, 2019 10:36 pm
I implemented this as a pull request a while ago (I have source access), and it was just accepted. It should be in 0.17.57. Pretty lucky too, I thought the devs wouldn't accept it until 0.18.

Added base_productivity to assembling machines, mining drill, and lab prototypes.
Added LuaEntityPrototype::base_productivity read.
Awesome :)! Thank you very much.
/me looks at date... are you working on "cleaning up" the mod request forum ;)?

Hm...what about furnaces? Are they more difficult?

Re: Assembling-machine with built-in productivity

Posted: Mon Jul 15, 2019 4:46 pm
by Boodals
eradicator wrote:
Mon Jul 15, 2019 11:49 am
Hm...what about furnaces? Are they more difficult?
Furnaces are crafting machines AKA assemblers. I guess I should have been clearer in the changelog.

Re: Assembling-machine with built-in productivity

Posted: Mon Jul 15, 2019 6:00 pm
by eradicator
Boodals wrote:
Mon Jul 15, 2019 4:46 pm
eradicator wrote:
Mon Jul 15, 2019 11:49 am
Hm...what about furnaces? Are they more difficult?
Furnaces are crafting machines AKA assemblers. I guess I should have been clearer in the changelog.
Great :).