Assembling-machine with built-in productivity

Rseding91
Factorio Staff
Factorio Staff
Posts: 13209
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Assembling-machine with built-in productivity

Post by Rseding91 »

Optera wrote:
Sun Jul 14, 2019 6:42 am
Boodals wrote:
Sat Jul 13, 2019 10:36 pm
I implemented this as a pull request a while ago (I have source access), and it was just accepted. It should be in 0.17.57. Pretty lucky too, I thought the devs wouldn't accept it until 0.18.

Added base_productivity to assembling machines, mining drill, and lab prototypes.
Added LuaEntityPrototype::base_productivity read.
To me this reads as if the productivity value was only writable in data stage, or does this allow creating an assembler based entity gaining productivity from research like mining drills.
Just data stage. Like setting the speed of an assembling machine you can now set the base productivity.
If you want to get ahold of me I'm almost always on Discord.

User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2916
Joined: Sat Jun 11, 2016 6:41 am
Contact:

Re: Assembling-machine with built-in productivity

Post by Optera »

Rseding91 wrote:
Sun Jul 14, 2019 12:20 pm
Optera wrote:
Sun Jul 14, 2019 6:42 am
Boodals wrote:
Sat Jul 13, 2019 10:36 pm
I implemented this as a pull request a while ago (I have source access), and it was just accepted. It should be in 0.17.57. Pretty lucky too, I thought the devs wouldn't accept it until 0.18.

Added base_productivity to assembling machines, mining drill, and lab prototypes.
Added LuaEntityPrototype::base_productivity read.
To me this reads as if the productivity value was only writable in data stage, or does this allow creating an assembler based entity gaining productivity from research like mining drills.
Just data stage. Like setting the speed of an assembling machine you can now set the base productivity.
Too bad, guess we can't get rid of hidden beacons yet.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Assembling-machine with built-in productivity

Post by eradicator »

Boodals wrote:
Sat Jul 13, 2019 10:36 pm
I implemented this as a pull request a while ago (I have source access), and it was just accepted. It should be in 0.17.57. Pretty lucky too, I thought the devs wouldn't accept it until 0.18.

Added base_productivity to assembling machines, mining drill, and lab prototypes.
Added LuaEntityPrototype::base_productivity read.
Awesome :)! Thank you very much.
/me looks at date... are you working on "cleaning up" the mod request forum ;)?

Hm...what about furnaces? Are they more difficult?
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Boodals
Fast Inserter
Fast Inserter
Posts: 129
Joined: Sun Feb 11, 2018 7:10 pm
Contact:

Re: Assembling-machine with built-in productivity

Post by Boodals »

eradicator wrote:
Mon Jul 15, 2019 11:49 am
Hm...what about furnaces? Are they more difficult?
Furnaces are crafting machines AKA assemblers. I guess I should have been clearer in the changelog.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Assembling-machine with built-in productivity

Post by eradicator »

Boodals wrote:
Mon Jul 15, 2019 4:46 pm
eradicator wrote:
Mon Jul 15, 2019 11:49 am
Hm...what about furnaces? Are they more difficult?
Furnaces are crafting machines AKA assemblers. I guess I should have been clearer in the changelog.
Great :).
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Post Reply

Return to “Implemented mod requests”