Factorio Forums

BaggyK wrote: ↑Sun Dec 06, 2020 11:06 am I read it as he wants to filter the output of the read train contents by wagon. So he could say tell me the contents of the first wagon of the train.

ssilk wrote: What do you want to do?

ssilk wrote: ↑Tue Dec 08, 2020 6:04 am Understood. But as said: very low chance of implementation, because low general gameplay value and high added complexity.\

oleg4f wrote: ↑Tue Dec 08, 2020 8:54 am but filtering on the *wagon* basis don't seem complex.

ssilk wrote: ↑Wed Dec 09, 2020 5:57 am Oh, I meant with complex here not just complex in the sense of programming, but for the player.

Open question here: what if both signals are set? Not logical self-explained, which is difficult for players.

But except for that it looks simple, also for the blacklisted signals, but as developer I would think: that is really an effort, because it needs extra buffers, because otherwise it needs to sum all wagons each tick. And with very long trains this is a bit of performance issue.

void
calc_sum(struct train *tr, uint64_t* tsfwmask)
{
	uint64_t wagon_mask[MAX];
	
	// set wagons mask from a train stop filter wagon mask
	for(int i = 0; i < MAX; i++)
		wagon_mask[i] = 0xffffffffffffffff & tsfwmask[i];
	for(int i = 0; i < tr->wagon_cnt; i++)
		if ((wagon_mask[i / 64] & (1 << (i%64)))
			train_add_wagon_items_to_sum(tr, i);
}

And why not doing the blacklisting yourself, because that is the content of the whole train, minus the content of the wagon. So you need just to read train content, remember that and then read wagon content and subtract it. Takes two ticks.

I mean, that are legit thoughts, because the use-case of the blacklisted contents, they are really so rare and it would remove this illogical conflicting signal-state, if both is set, when it would not be implemented.

Oh, and what I forgot: this cries for implementation as mod. Really not so difficult I think.

oleg4f wrote: ↑Thu Dec 10, 2020 10:33 am What are these both signals? I don't understand you. In my view this should be *the same* settings as in the filter inserter. A player choose two things:
- white or black list switch
- the content of chosen list

But content is wagon numbers, instead of items(like in filter inserter). That's it. What difficulties can be here for player?

The talk about an implementation is meaningless, because i didn't see the source. But. We already done sum of all items from all wagons. And white filter can make this process even faster. For examle:

Code: Select all

void
calc_sum(struct train *tr, uint64_t* tsfwmask)
{
	uint64_t wagon_mask[MAX];
	
	// set wagons mask from a train stop filter wagon mask
	for(int i = 0; i < MAX; i++)
		wagon_mask[i] = 0xffffffffffffffff & tsfwmask[i];
	for(int i = 0; i < tr->wagon_cnt; i++)
		if ((wagon_mask[i / 64] & (1 << (i%64)))
			train_add_wagon_items_to_sum(tr, i);
}

ssilk wrote: ↑Fri Dec 11, 2020 6:34 am We seem to have a communication problem,

because you haven’t written that till yet.

ssilk wrote: ↑Sat Dec 12, 2020 9:04 am And with a mask you don’t need blacklist/whitelist.